Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tor to 0.4.8.10 from 0.4.8.5 #12617

Merged
merged 3 commits into from Mar 6, 2024

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Mar 5, 2024

Fixes #12347

Changelog

Changelog mentions:

Some security issues but mostly for relay operators and for onion services, and a conflux bug:

o Major bugfixes (conflux):
- Fix an issue that prevented us from pre-building more conflux sets
after existing sets had been used. Fixes bug 40862; bugfix
on 0.4.8.1-alpha.

Testing

  • I can run binaries on Windows and linux.
  • On a macOS arm64 machine, I can see tor process reporting it is for the arm64 arch. So that looks ok too.

Resources

Older upgrades:

Comment on lines +48 to +50
$windowsInstaller = "tor-browser-windows-x86_64-portable-${version}.exe"
$macDmg = "tor-browser-macos-${version}.dmg"
$linuxTarball = "tor-browser-linux-x86_64-${version}.tar"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binaries got changed. Hopefully, the dmg for macOS is still for both intel and arm64 archs.

Copy link
Collaborator

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cr utACK. Checked binary name changes and that hashes of Linux binaries match https://www.torproject.org/dist/torbrowser/13.0.10/tor-browser-linux-x86_64-13.0.10.tar.xz.

{ OSPlatform.OSX, "ba028d74610083102c1f9cb95e6e746e3c0d374d61e275d3049729260900cb8b" },
{ OSPlatform.Windows, "33049016dd8985e97e69d89cad74b59b06488310c0be86d0f83b10ee096b7875" },
{ OSPlatform.Linux, "8f5f89e8dec6f4fa095ee10a9b16904cdb8a3d3f109d3b2929ff960ca15846ba" },
{ OSPlatform.OSX, "0360821eeb291e290f09966af87e7a1ceaba6d0a4b60e11c15249aeef288d49b" },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be probably extended to also check hashes of bundled dynamic libraries?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes, but it would require a proposal how to do it so that others can easily verify. I'm not really sure what is the instrustry standard (one can hash one file at a time, keep hashing while traversing directory, etc.).

@kiminuo kiminuo marked this pull request as ready for review March 6, 2024 07:51
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tack 0bff633 on debian 12
successfully sent & received and did a coinjoin on mainnet.

I didn't verify all the hashes

Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Tested on mac intel and arm. Works!

@molnard molnard merged commit 226d843 into zkSNACKs:master Mar 6, 2024
4 checks passed
@kiminuo kiminuo deleted the feature/2024-03-05-Upgrade-Tor branch March 6, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Tor
4 participants