Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Unobserved exceptions #8081

Conversation

kiminuo
Copy link
Contributor

@kiminuo kiminuo commented May 19, 2022

Might address #8053

This PR shows that my PRs on NBitcoin's side:

might help us get rid of those unobserved exceptions.

So I created NBitcoin's fork so that I'm actually able to show how it would behave if my PRs were merged in NBitcoin1:

cc @adamPetho @Szpoti would be great if you guys could test this PR if it helps with the issue. It might not be solved fully, the goal is to improve where we are not solve it completely as that would require probably long term commitment.

Footnotes

  1. It's not my goal to work on an NBitcoin's fork :)

Copy link
Contributor

@Szpoti Szpoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, the overwhelming log messages can't be seen when downloading filters.

@stale
Copy link

stale bot commented Jul 30, 2022

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 30, 2022
@yahiheb yahiheb removed the stale label Jul 30, 2022
@stale
Copy link

stale bot commented Sep 30, 2022

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 30, 2022
@stale stale bot closed this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants