Issue with whitespaces and byteoffset

[bnjjj]

I try to use miette with a parser, if the node parsed is of type error then I use miette to render the error. I have an issue because in miette it seems you're skipping '\n' and whitespaces into the source code. Then when I try to specify my SourceSpan thanks to the byte position it doesn't work at all because it the byte position with whitespaces and in your code you use the source_code string without any whitespaces.

How can I do this correctly ?

example of my code:

let err = ParsingError {
	bad_bit: (node.start_byte(), node.end_byte()).into(), // ISSUE HERE
	src: src.to_string(),
};

[zkat]

Oh this is a pretty good bug. So what you're trying to do is point at the newline whitespace itself?

[jmackie]

Don't mind me, just passing through, but I noticed:

bad_bit: (node.start_byte(), node.end_byte()).into(), // ISSUE HERE

Should that not be...

bad_bit: (node.start_byte(), node.end_byte() - node.start_byte()).into(),

As the convert impl says (start, len)?

[zkat]

oh yeah. That'd do it. Spans in miette are (offset, len), not (start, end), for some good reasons :)

[bnjjj]

Ok it's better now ! Thanks a lot ! My prediction about the bug with whitespaces was wrong. Sorry for this. I made a pr to have less confusion next time