Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @zkfs/examples run against the latest (@latest) deployed packages #33

Open
maht0rz opened this issue Feb 12, 2023 · 1 comment
Open

Comments

@maht0rz
Copy link
Contributor

maht0rz commented Feb 12, 2023

Update: We use @latest instead of @next now

Since stackblitz doesnt work well with npm workspaces, we can't run @zkfs/examples in stackblitz while using locally built and linked @zkfs/contract-api.

Stackblitz shows @zkfs/examples from the develop branch, but relies on the @next release of our packages. @next packages are released every time a push to develop is made and there are code changes to deploy.

This means there is room for inconsistencies across our CI/CD pipeline, if a deployment of a @next package fails, then stackblitz will point to the latest develop examples but will run older @next packages.

We should make the CI/CD pipeline run @zkfs/examples after publishing @next packages, so that we can be aware of the working status of the stackblitz example.

It won't unpublish/fix the underlying inconsistency, but it will alert us as developers to fix the actual issue with the pipeline.

@maht0rz
Copy link
Contributor Author

maht0rz commented Feb 13, 2023

After recent updates, develop is published as @latest (+ canary) and the stackblitz example points to that release as well. However the underlying consistency issue still persists.

@maht0rz maht0rz changed the title Make @zkfs/examples run against the latest (@next) deployed packages Make @zkfs/examples run against the latest (@latest) deployed packages Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Freezer
Development

No branches or pull requests

1 participant