Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curiousity killed the cat #2

Open
andreineculau opened this issue Dec 10, 2017 · 3 comments
Open

curiousity killed the cat #2

andreineculau opened this issue Dec 10, 2017 · 3 comments

Comments

@andreineculau
Copy link

Why do you say it's unsafe to ignore test.js and example.js ?

And why do you say it's safe to ignore AUTHORS files? it's not actually. both AUTHORS and NOTICE :s

@zkochan
Copy link
Owner

zkochan commented Dec 10, 2017

my initial assumption was that it is unsafe to ignore any code file and safe to remove docs/markdowns and other plain text files. I was warned that removing license is not good from the legal perspective.

@andreineculau
Copy link
Author

hmm, it's peculiar though. READMEs are safe to delete, but not example.js. Same for the test folder but not test.js..

regarding AUTHORS and NOTICE - they follow in the legal bucket, as the LICENSE may say that all rights are reserved to those mentioned in the AUTHORS file, and/or that reuse of the work need to embed the NOTICE

@zkochan
Copy link
Owner

zkochan commented Dec 10, 2017

yes, the test folder should be treated same way as test.js. That is a mistake.

Regarding AUTHORS and NOTICE. The LICENSE file can say anything.

And also, what safe, what is unsafe is super-subjective. I'd prefer removing the distinction and having just the unsafe set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants