Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repositories with no description cause an error #50

Closed
zkoppert opened this issue Sep 22, 2023 · 2 comments · Fixed by #51
Closed

repositories with no description cause an error #50

zkoppert opened this issue Sep 22, 2023 · 2 comments · Fixed by #51
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zkoppert
Copy link
Owner

Repositories that don't have a description cause the following error:

Traceback (most recent call last):
  File "/action/workspace/crawler.py", line 84, in <module>
    innersource_repo["score"] = repo_activity.score.calculate(
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.[11](https://github.com/innersource-portal-demo/project-portal-for-innersource/actions/runs/6279610170/job/17055587875#step:4:12)/site-packages/repo_activity/score.py", line 54, in calculate
    len(repo["description"]) > 30
    ^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: object of type 'NoneType' has no len()

A workaround is to add a description but it would be better if the crawler could handle repositories without descriptions gracefully and continue running.

@zkoppert zkoppert added bug Something isn't working good first issue Good for newcomers labels Sep 22, 2023
@issamansur
Copy link
Contributor

issamansur commented Sep 23, 2023

Can I help with this?
What we need to do if description didn't exist? Pass or doing something?

@zkoppert
Copy link
Owner Author

Yeah that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants