Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes #462

Closed
zkrising opened this issue Apr 28, 2021 · 1 comment
Closed

Classes #462

zkrising opened this issue Apr 28, 2021 · 1 comment
Labels
Port From Kamaitachi This is a feature port from KT1

Comments

@zkrising
Copy link
Owner

Formally known as dans, but named classes in Kamaitachi so it can also be used for jubeat's colours and so on.

These should be ported. Could be handled in score-import-main.ts as a post-cycle hook. probably.

I guess the main issue is actually knowing when or how to update these. Certain requests (mainly IR requests) provide metadata that lets us update classes. Sometimes, a class is dependent on a rating property instead of IR info (i.e. skill > 6000, rather than IR saying you are kaiden), so this definitely seems rather import-dependent.

We could have something like a set of importType "handle class update" hooks, but maybe they'd need to be returned from the parser as things like file/json:batch-manual could cause obvious generic-issues.

Will sleep on it, but could be more of a pain than initially thought.

@zkrising zkrising added the Port From Kamaitachi This is a feature port from KT1 label Apr 28, 2021
@zkrising
Copy link
Owner Author

Merged wtih #460

@zkrising zkrising transferred this issue from another repository Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Port From Kamaitachi This is a feature port from KT1
Projects
None yet
Development

No branches or pull requests

1 participant