Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display public input in kimchi and R1CS ASM #65

Closed
mimoo opened this issue May 10, 2024 · 2 comments
Closed

Display public input in kimchi and R1CS ASM #65

mimoo opened this issue May 10, 2024 · 2 comments
Labels

Comments

@mimoo
Copy link
Contributor

mimoo commented May 10, 2024

currently the ASM for kimchi does not display the public input. For example https://github.com/zksecurity/noname/blob/main/examples/arithmetic.asm

@ noname.0.7.0

DoubleGeneric<1>
DoubleGeneric<1,1,-1>
DoubleGeneric<1,0,0,0,-2>
(0,0) -> (1,1)
(1,2) -> (2,0)

we should figure out a way to display the public input there. For example we could have a pub: prefix in front of the gates that are for the public input, but this is a bit ugly and verbose, or we could have the number of public inputs displayed on the second line (like @ public_inputs: 1)

@ noname.0.7.0
+ @ public_inputs: 1

DoubleGeneric<1>
DoubleGeneric<1,1,-1>
DoubleGeneric<1,0,0,0,-2>
(0,0) -> (1,1)
(1,2) -> (2,0)

for R1CS maybe we could write something like this:

@ noname.0.7.0
+ @ v_0=1
+ @ pub=v_1 to v_3

v_3 == (v_3) * (1)
v_4 == (v_4) * (1)
v_3 == (v_1) * (1)
v_4 + 1 == (v_2) * (1)

but yeah haven't thought much about this one, open to suggestions

@mimoo mimoo added the easy label May 10, 2024
@mimoo mimoo mentioned this issue May 10, 2024
3 tasks
@mimoo mimoo changed the title Display public input in kimchi ASM Display public input in kimchi and R1CS ASM Jun 1, 2024
@mantej
Copy link
Contributor

mantej commented Sep 22, 2024

@mimoo public inputs PR merged!

@mimoo mimoo closed this as completed Sep 22, 2024
@mimoo
Copy link
Contributor Author

mimoo commented Sep 22, 2024

nice! thanks again man :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants