-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breakthrough] Occasional Anonymity Loss #10708
Comments
That's a good catch, sounds about right. |
You rediscovered #10096 and #8938; this is exactly the issue explained and tried to be mitigated by implementing these points: And by the way, your example would be much worse the other way around:
Like this, the user is losing much more global %
|
@turbolay it seems you're conflating what our anonymity calculation says about privacy loss and the actual privacy loss is and thus you're bringing in many issues needlessly like #10096 or your example:
It's not actually bad for privacy, only for our anonymity calculation thinks so, and by the way it is the fix: #10699 However what's going on in this very issue is bad for privacy, not only our anonymity calculations say so. |
@turbolay Could you elaborate/copy paste the relevant text on this one here?
|
Sure! Creating more outputs for whales as you suggested is a good and effective way to reduce this change Let me also drop here an observation that I made on Slack and that I think relevant here: https://tumblebit.slack.com/archives/CFBJX6MN0/p1682306405947139 Backup of the Slack comment:I think that this Coinjoin is a really good example of why sometimes we have bad consolidation, at least with the naive decomposer (Lucas’ decomposer is a black box for me): https://mempool.space/tx/2f74c5a88ce9279a68ba11305e425087648858f6d5315aa475298587e71b977a |
Status UpdateThis issue is nearly resolved at this point, although there's still an unexplored territory for improvements. Let me explain: there are 3 paths one can take to improve upon this:
|
Status Update
|
What is missing to finish this? |
It's fixed, I only want to put the cherry on top of the cake: whale rounds. It will take some time before I get there. |
Are you getting back to this? |
I am working on this. |
@nopara73 do you have news about this issue? Thank you! |
I am working on this. |
Only remaining thing here is: #11676 |
The past days I have been investigating a user's anonymity loss and I think I have finally arrived to a theory that explains it. I examined a number of testnet and mainnet wallets and this case is present about 0.1% of the times. It happens much more often for whales or plebwhales.
Take a transaction when the user comes with these coins:
The rest of the users come with many coins between 100 and 3 and many under 3.
Let's say we create an output 105 and other smaller ones.
In this case this output of ours receives an anonymity of 1 and let's say the rest of our outputs receives high anonymities.
The total anonymity loss here is roughly
(100 + 3000 + 2000 + 1000) - (105 + a little bit) ~
6000.And unfortunately the anonymity loss here is completely justified!
So, this means we have to fix the whale UX,
Also note this issue is aggravated by ideas those aim to increase input counts like @MaxHillebrand's here: #10681 or @turbolay's here: #10678 (comment)
The text was updated successfully, but these errors were encountered: