Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible list of suggested labels while textbox is empty #10864

Closed
yahiheb opened this issue Jun 9, 2023 · 3 comments · Fixed by #10870
Closed

Visible list of suggested labels while textbox is empty #10864

yahiheb opened this issue Jun 9, 2023 · 3 comments · Fixed by #10870
Labels

Comments

@yahiheb
Copy link
Collaborator

yahiheb commented Jun 9, 2023

How to reproduce:

  • Go to Receive dialog
  • Type one character
  • Delete it
  • See the list of suggested labels

Capture

@yahiheb yahiheb added the UI label Jun 9, 2023
@soosr
Copy link
Contributor

soosr commented Jun 9, 2023

This is fine, the intention is clear for the user, they want to enter a label just mistyped the first letter (or more). It is ok to have the suggestion visible.

@soosr soosr closed this as completed Jun 9, 2023
@yahiheb
Copy link
Collaborator Author

yahiheb commented Jun 9, 2023

But why should we keep it displayed? We already have the top most used suggestion under the textbox.
If it is helpful for the user then why not make this list visible as soon and the textbox is focused.

@soosr
Copy link
Contributor

soosr commented Jun 9, 2023

I checked how others do it. They either open the suggestions as soon as the control has the focus or close it when the input field is empty.
Since the top suggestions would be covered if opened the suggestions on focus, I would go with your suggestions to close it when the field is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants