Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Moq package #11244

Closed
lontivero opened this issue Aug 9, 2023 · 3 comments
Closed

Remove Moq package #11244

lontivero opened this issue Aug 9, 2023 · 3 comments

Comments

@lontivero
Copy link
Collaborator

The package Moq v4.20.0 started to sending the user's hashed email address to a central server.

Given many of our users are rather advanced we could expect many of them are cloning the repo and building from source and in that way they would be leaking their emails (it doesn't matter whether it is hashed or not)

We are not using the "evil" version yet but given the nature of our project we cannot have Moq.

Read: https://github.com/moq/moq/issues/1372

@lontivero lontivero mentioned this issue Aug 11, 2023
@lontivero lontivero reopened this Aug 13, 2023
@lontivero
Copy link
Collaborator Author

It was not removed, There are still 10 or so cases we need to solve before removing it.

@stale
Copy link

stale bot commented Oct 15, 2023

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@yahiheb yahiheb removed the stale label Oct 15, 2023
@lontivero
Copy link
Collaborator Author

This is not a priority anymore given the library changed the problematic behavior. However, having a mock library is not good and we should remove it eventually, otherwise we risk devs start using it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants