Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Warning incorrect message #11296

Closed
RolandUI opened this issue Aug 15, 2023 · 4 comments · Fixed by #11610
Closed

Privacy Warning incorrect message #11296

RolandUI opened this issue Aug 15, 2023 · 4 comments · Fixed by #11610
Assignees

Comments

@RolandUI
Copy link
Contributor

RolandUI commented Aug 15, 2023

When everything is perfect we say "Your privacy is well protected in this transaction" while this is not 100% correct as there are items that are not related to privacy.

A solution would be to rephrase/rethink the whole feature. It could be Transaction Warning instead of Privacy Warning.
Up for discussion.

Image

@nopara73
Copy link
Contributor

nopara73 commented Sep 1, 2023

This transaction is in line with common best practices.
This transaction is consistent with established best practices.
In the realm of best practices, this transaction is a masterpiece.
This transaction dances gracefully to the tune of best practices.

@Kruwed
Copy link
Contributor

Kruwed commented Sep 1, 2023

There are certain instances where the message "This transaction creates change" is displayed when hovering over the green shield. The reason the icon remains green is because there is no reasonable way to send that amount and avoid change using the UTXOs available. Perhaps the best descriptions to cover all scenarios where a green shield appears are "Your privacy is maximized in this transaction" or "This transaction has optimal privacy."

@nopara73
Copy link
Contributor

nopara73 commented Sep 2, 2023

@Kruwed, am I misunderstanding you, or are you not seeing the main issue here? The problem here is "privacy." We should consider a broader term like "transaction quality" to encompass not just privacy but other aspects as well. Something that includes but not limited to the property of privacy.

@Kruwed
Copy link
Contributor

Kruwed commented Sep 2, 2023

Ah, I misunderstood. That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants