Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to disable auto coinjoin directly in the recovery workflow #12280

Closed
turbolay opened this issue Jan 18, 2024 · 7 comments
Closed

Comments

@turbolay
Copy link
Collaborator

Currently, users are shown during the recovery workflow (profile selection screen) that the Coinjoin service will start automatically, but the screen doesn't provide a way to disable it.

I know that the profile selection will be removed and that now after recovery the service won't start automatically, but still, we would need a screen that explains coinjoin fee and provides a way to say "I do not want to automatically start coinjoining", otherwise the user might think that he has to pay for using the wallet, which is not the case.

@fulldecent
Copy link
Contributor

Here is the screen we are talking about

297597652-e6e9eb84-ea09-4b92-ac3b-5f904467232d

Currently you must select one of these three actions to proceed with wallet import.

We are missing a fourth option "no, I don't want this".


Also, maybe there is instead a way to delay this (what I find) unacceptably scary message until later in the onboarding process. Possibly if coinjoin is only used at certain times or when making transactions or something then this could be shown later, at that time.

@nostitos
Copy link

It's incredible how deep that disable feature is,
Why would it not just be part of the start/stop/pause button?

@RolandUI
Copy link
Contributor

Currently, on master, it can be disabled by clicking on Customize and just turning off the auto start. Which will be released soon, so I guess this issue is already solved?

@turbolay
Copy link
Collaborator Author

Thanks @soosr , didn't know that

@fulldecent
Copy link
Contributor

May a screenshot of the new behavior please be attached to this ticket when closing?

@turbolay
Copy link
Collaborator Author

CleanShot.2024-01-22.at.07.20.07.mp4

@fulldecent
Copy link
Contributor

Awesome, thank you, I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants