Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To darkmode, or not to darkmode? #54

Closed
MaxHillebrand opened this issue Aug 3, 2019 · 6 comments
Closed

To darkmode, or not to darkmode? #54

MaxHillebrand opened this issue Aug 3, 2019 · 6 comments

Comments

@MaxHillebrand
Copy link
Contributor

MaxHillebrand commented Aug 3, 2019

The question is simple:

Do you like your eyes bleeding?

If the answer is no, then the only logical solution is to make the docs in dark mode.

Why Dark Mode?

  • A paper is white by default, thus we use black inc to write. A screen is black by default, thus we use white pixels to write.
  • The high contrast of dark background and white text is a lot easier to read.
  • Wasabi GUI is already dark mode.
  • Bitcoin is already boiling the oceans, so we should save energy, and dark pixels need less electricity than white ones.

Why White Mode?

  • It might be an adventure to be blind due to white screen radiation.
  • Education is not important, so nobody needs to read the docs anyway.
  • Babies are dying.

Comparison

screenshot_20190803_091827

Looks nice, right? [The button should have a different color]

screenshot_20190803_091846

Sorry for making your eyes cry...

screenshot_20190803_091920

Easy to read, right? [The highlighted links will be the same color, this is a bug in my dark mode plugin]

screenshot_20190803_091908

Yeah, you don't want to continue reading, right?

Consideration

It is possible, although related to a lot of development and extra code, to have a toggle to switch between white and dark mode. Here it would be important to remember the setting in the last session, which is again more code...

Let's see what the community says.

@infominer33
Copy link

I think if you have such strong opinions, and you are doing the work, then just do it how you like...

@dennisreimann
Copy link
Contributor

We should just leverage the CSS prefers-color-scheme property, then we are good to go and support the users preferences. It's not much work and I can implement that later today.

@yahiheb
Copy link
Collaborator

yahiheb commented Aug 3, 2019

To darkmode.

dennisreimann added a commit that referenced this issue Aug 3, 2019
This uses the CSS media query prefers-color-scheme to adapt to the users system settings. Closes #54.

See these for details:
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme
https://twitter.com/DennisReimann/status/1157714320324747265

Signed-off-by: Dennis Reimann <mail@dennisreimann.de>
@dennisreimann
Copy link
Contributor

I have implemented this in #53 – let's keep track of this feature request there.

@yahiheb
Copy link
Collaborator

yahiheb commented Mar 21, 2020

Any one has an idea how to change the mode?

@dennisreimann
Copy link
Contributor

Via your OS’ system preferences. That‘s a CSS based solution that uses with the OS/browser settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants