Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split archive bug #669

Closed
mileta-r opened this issue Jan 31, 2023 · 1 comment
Closed

Split archive bug #669

mileta-r opened this issue Jan 31, 2023 · 1 comment
Labels
disk splitting Disk spanning

Comments

@mileta-r
Copy link

mileta-r commented Jan 31, 2023 •
edited

When creating a split archive minizip on Windows10 machine creates thousands of empty files.
To reproduce unpack the attached file to a "SplitZipTest" folder and try to create a new archive with:
minizip.exe -v -5 -k 200 SplitZip.zip path\to\SplitZipTest\*
SplitZip.zip
nmoinvaz added a commit that referenced this issue Feb 12, 2023
@nmoinvaz
Fixed split disk archives being created with 0 bytes. #669
a0d9040 
After the first disk, disks would be created with zero size. This would happen
when using MZ_ZIP_FLAG_DATA_DESCRIPTOR or MZ_ZIP_FLAG_MASK_LOCAL_INFO, because
we were changing the disk properly when going to update local file info headers.
nmoinvaz added a commit that referenced this issue Feb 12, 2023
@nmoinvaz
Fixed split disk archives being created with 0 bytes. #669
23f66e9 
After the first disk, disks would be created with zero size. This would happen
when using MZ_ZIP_FLAG_DATA_DESCRIPTOR or MZ_ZIP_FLAG_MASK_LOCAL_INFO, because
we were changing the disk properly when going to update local file info headers.
@nmoinvaz
Copy link
Member

This should be resolved now in the develop branch. Thanks.

@nmoinvaz nmoinvaz added the disk splitting Disk spanning label Feb 12, 2023
@ptc-tgamper ptc-tgamper mentioned this issue Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
disk splitting Disk spanning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nmoinvaz @mileta-r