fix_zstd_libraries_cmake #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmoinvaz
reviewed
Feb 11, 2021
| set(ZSTD_VERSION ${ZSTD_VERSION_STRING}) | ||
| if(ZSTD_FOUND) | ||
| set(ZSTD_VERSION ${ZSTD_VERSION_STRING}) | ||
| if(TARGET libzstd_static) |
There was a problem hiding this comment.
Perhaps this should be:
if(NOT DEFINED BUILD_SHARED_LIBS OR NOT ${BUILD_SHARED_LIBS})
Like on line 379.
There was a problem hiding this comment.
because there is not always the case that we would get shared libs, for e.g. if vcpkg is used to link zstd in Linux, then build would fail, because vcpkg don't support shared in linux
| set(ZSTD_VERSION ${ZSTD_VERSION_STRING}) | ||
| if(ZSTD_FOUND) | ||
| set(ZSTD_VERSION ${ZSTD_VERSION_STRING}) | ||
| if(TARGET libzstd_static) |
There was a problem hiding this comment.
Why not do:
set(ZSTD_LIBRARIES libzstd_static)
Then we can use:
list(APPEND MINIZIP_LIB ${ZSTD_LIBRARIES})
down below in if(ZSTD_FOUND AND NOT MZ_FORCE_FETCH_LIBS) like before?
There was a problem hiding this comment.
i can simplify this a bit, i just added this because I thought it would be pointless to add
set(PC_PRIVATE_LIBS "${PC_PRIVATE_LIBS} -lzstd")
list(APPEND MINIZIP_DEP_PKG ZSTD)if we are linking statically, but after further thinking, it would fail if minizip is itself is static
prateek9623
force-pushed
the
fix_zstd_libraries_cmake
branch
from
2b0c121
to
11d2dd1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes zstd linking with find_package