Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption support on UWP #674

Merged
merged 4 commits into from Feb 16, 2023
Merged

Conversation

sergio-nsk
Copy link
Contributor

@sergio-nsk sergio-nsk commented Feb 14, 2023

I am stuck on PKCS7 signing. Let keep BCrypt and NCrypt w/o mz_crypt_sign() and mz_crypt_sign_verify() in this PR.
Also I am stuck on building the tests for UWP. It sucks on application manifest files, a manifest file in one project breaks build of another project with another manifest file.

@sergio-nsk sergio-nsk marked this pull request as draft February 14, 2023 21:30
@sergio-nsk sergio-nsk force-pushed the sergio-nsk/winrt/1 branch 4 times, most recently from a829c8c to 15afeb6 Compare February 14, 2023 21:45
mz_crypt_winrt.c Outdated Show resolved Hide resolved
test/test_crypt.cc Show resolved Hide resolved
test/test_crypt.cc Show resolved Hide resolved
@sergio-nsk sergio-nsk force-pushed the sergio-nsk/winrt/1 branch 6 times, most recently from 37dbfd6 to 17409ce Compare February 15, 2023 19:37
@sergio-nsk sergio-nsk force-pushed the sergio-nsk/winrt/1 branch 2 times, most recently from 31c80da to 7d888ac Compare February 15, 2023 22:35
@sergio-nsk sergio-nsk marked this pull request as ready for review February 16, 2023 00:00
Copy link
Member

@nmoinvaz nmoinvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few feedback..

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@nmoinvaz nmoinvaz merged commit 357ae00 into zlib-ng:develop Feb 16, 2023
@nmoinvaz nmoinvaz added the encryption Encryption/decryption issue label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encryption Encryption/decryption issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants