-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encryption support on UWP #674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-nsk
force-pushed
the
sergio-nsk/winrt/1
branch
4 times, most recently
from
February 14, 2023 21:45
a829c8c
to
15afeb6
Compare
nmoinvaz
reviewed
Feb 14, 2023
sergio-nsk
force-pushed
the
sergio-nsk/winrt/1
branch
6 times, most recently
from
February 15, 2023 19:37
37dbfd6
to
17409ce
Compare
sergio-nsk
force-pushed
the
sergio-nsk/winrt/1
branch
2 times, most recently
from
February 15, 2023 22:35
31c80da
to
7d888ac
Compare
sergio-nsk
force-pushed
the
sergio-nsk/winrt/1
branch
from
February 15, 2023 23:50
7d888ac
to
ea22c96
Compare
nmoinvaz
reviewed
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few feedback..
Always ON on UWP and depends on a user choice or OFF otherwise.
nmoinvaz
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am stuck on PKCS7 signing. Let keep BCrypt and NCrypt w/o
mz_crypt_sign()
andmz_crypt_sign_verify()
in this PR.Also I am stuck on building the tests for UWP. It sucks on application manifest files, a manifest file in one project breaks build of another project with another manifest file.