mz_os_posix.c - fix warning caused by missing cast of return value of strdup #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to change the return type to |
|
It seems all functions that deal with UTF-8 strings use uint8_t*. I must admit I like that because it explicitly tells me that all bits of the byte are relevant for the character. |
…g_delete to take a char**
… be represented by char*; test_encoding.cc - remove useless cast
ptc-tgamper
commented
Jun 8, 2023
ptc-tgamper
commented
Jun 8, 2023
ptc-tgamper
commented
Jun 8, 2023
ptc-tgamper
commented
Jun 8, 2023
|
CI failure is caused by https://git.tukaani.org/xz.git/ not responding |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have run into #705, too.
Here is a fix.