Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSVC warnings in hash_head_0.c test #1002

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Fix MSVC warnings in hash_head_0.c test #1002

merged 1 commit into from
Jun 18, 2021

Conversation

iii-i
Copy link
Member

@iii-i iii-i commented Jun 14, 2021

@nmoinvaz I don't have MSVC at hand, but this should work - could you please give it a try?

@codecov
Copy link

codecov bot commented Jun 14, 2021 •
edited
Loading

Codecov Report

Merging #1002 (e0efff2) into develop (e2705f8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1002      +/-   ##
===========================================
+ Coverage    76.37%   76.38%   +0.01%     
===========================================
  Files           77       77              
  Lines         8250     8250              
  Branches      1342     1342              
===========================================
+ Hits          6301     6302       +1     
  Misses        1417     1417              
+ Partials       532      531       -1
Flag Coverage Δ
macos_clang 68.34% <100.00%> (ø)
macos_gcc 67.21% <100.00%> (ø)
ubuntu_clang 69.35% <100.00%> (ø)
ubuntu_clang_debug 68.76% <100.00%> (ø)
ubuntu_clang_inflate_allow_invalid_dist 69.11% <100.00%> (ø)
ubuntu_clang_inflate_strict 69.35% <100.00%> (ø)
ubuntu_clang_mmap 69.35% <100.00%> (ø)
ubuntu_clang_msan 69.35% <100.00%> (ø)
ubuntu_clang_pigz 35.34% <ø> (ø)
ubuntu_clang_pigz_no_optim 37.79% <ø> (ø)
ubuntu_clang_pigz_no_threads 34.99% <ø> (ø)
ubuntu_gcc 68.53% <100.00%> (ø)
ubuntu_gcc_aarch64 68.78% <100.00%> (ø)
ubuntu_gcc_aarch64_compat_no_opt 66.97% <100.00%> (ø)
ubuntu_gcc_aarch64_no_acle 67.69% <100.00%> (ø)
ubuntu_gcc_aarch64_no_neon 67.98% <100.00%> (ø)
ubuntu_gcc_armhf 68.75% <100.00%> (ø)
ubuntu_gcc_armhf_compat_no_opt 66.94% <100.00%> (ø)
ubuntu_gcc_armhf_no_acle 68.91% <100.00%> (ø)
ubuntu_gcc_armhf_no_neon 69.15% <100.00%> (ø)
ubuntu_gcc_armsf 68.76% <100.00%> (ø)
ubuntu_gcc_armsf_compat_no_opt 66.94% <100.00%> (ø)
ubuntu_gcc_compat_no_opt 68.42% <100.00%> (ø)
ubuntu_gcc_mingw_i686 0.00% <0.00%> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <0.00%> (ø)
ubuntu_gcc_no_avx2 68.76% <100.00%> (ø)
ubuntu_gcc_no_pclmulqdq 66.71% <100.00%> (ø)
ubuntu_gcc_no_sse2 67.94% <100.00%> (ø)
ubuntu_gcc_no_sse4 66.89% <100.00%> (ø)
ubuntu_gcc_o3 68.31% <100.00%> (ø)
ubuntu_gcc_osb 70.86% <100.00%> (ø)
ubuntu_gcc_pigz 35.25% <ø> (ø)
ubuntu_gcc_ppc 68.91% <100.00%> (ø)
ubuntu_gcc_ppc64 69.78% <100.00%> (ø)
ubuntu_gcc_ppc64le 68.47% <100.00%> (ø)
ubuntu_gcc_s390x 67.79% <100.00%> (ø)
ubuntu_gcc_sparc64 70.07% <100.00%> (ø)
win64_gcc 70.16% <100.00%> (ø)
win64_gcc_compat_no_opt 73.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/hash_head_0.c 54.16% <100.00%> (ø)
functable.c 82.03% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2705f8...e0efff2. Read the comment docs.

nmoinvaz
nmoinvaz approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@nmoinvaz nmoinvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the warnings for me in MSVC.

@Dead2 Dead2 merged commit 834e7d8 into zlib-ng:develop Jun 18, 2021
Dead2 added a commit that referenced this pull request Jun 21, 2021
@Dead2
Version 2.0.5
f9d61dc 
- Fix inflate corruption on aarch64 #1008
- Fix MSVC warnings #1002
- Minor chunkset improvements #1000 #994
- Minor cleanup #997
- Add CI test for pigz on aarch64 #1004
- Cmake improvements #996
@Dead2 Dead2 mentioned this pull request Jun 21, 2021
Merged
Dead2 added a commit that referenced this pull request Jun 21, 2021
@Dead2
Version 2.0.5
feb12cd 
- Fix inflate corruption on aarch64 #1008
- Fix MSVC warnings #1002 #1013
- Minor chunkset improvements #1000 #994
- Minor cleanup #997
- Add CI test for pigz on aarch64 #1004
- Cmake improvements #996
Dead2 added a commit that referenced this pull request Jun 22, 2021
@Dead2
Version 2.0.5
88ffff5 
- Fix inflate corruption on aarch64 #1008
- Fix MSVC warnings #1002 #1013
- Minor chunkset improvements #1000 #994 #1015
- Minor cleanup #997
- Add CI test for pigz on aarch64 #1004
- Cmake improvements #996
Dead2 added a commit that referenced this pull request Jun 25, 2021
@Dead2
Version 2.0.5
c69f78b 
- Fix inflate corruption on aarch64 #1008
- Fix MSVC warnings #1002 #1013
- Minor chunkset improvements #1000 #994 #1015
- Minor cleanup #997
- Add CI test for pigz on aarch64 #1004
- Cmake improvements #996
@iii-i iii-i deleted the hash-head-0-msvc branch April 20, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmoinvaz nmoinvaz nmoinvaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iii-i @nmoinvaz @Dead2