-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Z_UNUSED define for ignore unused variables. #997
Conversation
I think the name is acceptable as it follows our naming style. |
Codecov Report
@@ Coverage Diff @@
## develop #997 +/- ##
========================================
Coverage 76.37% 76.37%
========================================
Files 77 77
Lines 8250 8250
Branches 1342 1339 -3
========================================
Hits 6301 6301
Misses 1417 1417
Partials 532 532
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Previously mentioned in #418.
I have put it in zbuild.h for now and if we want to it can be moved. I can also rename it to
UNUSED()
ifZ_UNUSED
is not good name for zbuild.h.