Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize slide_hash using RVV #1522

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Optimize slide_hash using RVV #1522

merged 1 commit into from
Jun 23, 2023

Conversation

alexsifivetw
Copy link
Contributor

We use upstream toolchain and run it on SiFive internal FPGA /w p470 bitstream:

Benchmark Speedup (RVV / Scalar)
slide_hash/1024 7.727057765
slide_hash/2048 8.157694973
slide_hash/4096 8.529243135
slide_hash/8192 8.598595279
slide_hash/16384 8.149867804
slide_hash/32768 7.753176293

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (afd2a0c) 83.88% compared to head (867d76b) 83.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1522      +/-   ##
===========================================
+ Coverage    83.88%   83.90%   +0.01%     
===========================================
  Files          132      132              
  Lines        10841    10841              
  Branches      2792     2792              
===========================================
+ Hits          9094     9096       +2     
+ Misses        1048     1045       -3     
- Partials       699      700       +1     
Flag Coverage Δ
macos_clang 42.97% <ø> (ø)
macos_gcc 73.69% <ø> (ø)
ubuntu_clang 82.53% <ø> (ø)
ubuntu_clang_debug 82.16% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 81.95% <ø> (-0.23%) ⬇️
ubuntu_clang_inflate_strict 82.52% <ø> (ø)
ubuntu_clang_mmap 82.85% <ø> (ø)
ubuntu_clang_pigz 14.16% <ø> (-0.06%) ⬇️
ubuntu_clang_pigz_no_optim 11.61% <ø> (ø)
ubuntu_clang_pigz_no_threads 14.03% <ø> (+0.05%) ⬆️
ubuntu_clang_reduced_mem 82.70% <ø> (-0.23%) ⬇️
ubuntu_clang_toolchain_riscv ∅ <ø> (∅)
ubuntu_gcc 75.32% <ø> (ø)
ubuntu_gcc_aarch64 77.43% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 75.71% <ø> (?)
ubuntu_gcc_aarch64_no_acle 76.24% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 76.24% <ø> (ø)
ubuntu_gcc_armhf 77.50% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 75.66% <ø> (-0.02%) ⬇️
ubuntu_gcc_armhf_no_acle 77.45% <ø> (ø)
ubuntu_gcc_armhf_no_neon 77.35% <ø> (ø)
ubuntu_gcc_armsf 74.82% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 74.30% <ø> (+0.01%) ⬆️
ubuntu_gcc_benchmark 73.72% <ø> (ø)
ubuntu_gcc_compat_no_opt 76.88% <ø> (+0.01%) ⬆️
ubuntu_gcc_compat_sprefix 73.75% <ø> (ø)
ubuntu_gcc_m32 73.54% <ø> (+0.15%) ⬆️
ubuntu_gcc_mingw_i686 73.60% <ø> (ø)
ubuntu_gcc_mingw_x86_64 73.60% <ø> (-0.16%) ⬇️
ubuntu_gcc_mips 75.07% <ø> (ø)
ubuntu_gcc_mips64 75.08% <ø> (ø)
ubuntu_gcc_no_avx2 74.35% <ø> (ø)
ubuntu_gcc_no_ctz 74.81% <ø> (ø)
ubuntu_gcc_no_ctzll 74.80% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 74.34% <ø> (ø)
ubuntu_gcc_no_sse2 74.61% <ø> (ø)
ubuntu_gcc_no_sse42 74.79% <ø> (+0.55%) ⬆️
ubuntu_gcc_o1 74.24% <ø> (+0.05%) ⬆️
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 38.28% <ø> (-0.08%) ⬇️
ubuntu_gcc_pigz_aarch64 39.22% <ø> (+0.02%) ⬆️
ubuntu_gcc_ppc 74.08% <ø> (ø)
ubuntu_gcc_ppc64 74.51% <ø> (ø)
ubuntu_gcc_ppc64_power9 74.69% <ø> (ø)
ubuntu_gcc_ppc64le 74.52% <ø> (ø)
ubuntu_gcc_ppc64le_novsx 74.89% <ø> (ø)
ubuntu_gcc_ppc64le_power9 74.46% <ø> (ø)
ubuntu_gcc_ppc_no_power8 74.77% <ø> (ø)
ubuntu_gcc_s390x 74.96% <ø> (ø)
ubuntu_gcc_s390x_dfltcc 72.03% <ø> (ø)
ubuntu_gcc_s390x_dfltcc_compat 74.04% <ø> (ø)
ubuntu_gcc_s390x_no_crc32 74.75% <ø> (ø)
ubuntu_gcc_sparc64 74.89% <ø> (ø)
ubuntu_gcc_sprefix 73.40% <ø> (ø)
win64_gcc 74.14% <ø> (ø)
win64_gcc_compat_no_opt 74.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
functable.c 74.56% <ø> (ø)
test/benchmarks/benchmark_slidehash.cc 72.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Dead2 Dead2 merged commit 2f4ebe2 into zlib-ng:develop Jun 23, 2023
134 checks passed
@Dead2 Dead2 mentioned this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants