Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle complete overlap in chunkcopy_safe #1526

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

Vogtinator
Copy link
Contributor

Fixes #1525

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.01 🎉

Comparison is base (2f4ebe2) 83.88% compared to head (457dafd) 83.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1526      +/-   ##
===========================================
+ Coverage    83.88%   83.89%   +0.01%     
===========================================
  Files          132      132              
  Lines        10840    10842       +2     
  Branches      2792     2793       +1     
===========================================
+ Hits          9093     9096       +3     
+ Misses        1048     1047       -1     
  Partials       699      699              
Flag Coverage Δ
macos_clang 42.97% <ø> (ø)
macos_gcc 73.67% <0.00%> (-0.02%) ⬇️
ubuntu_clang 82.51% <50.00%> (-0.02%) ⬇️
ubuntu_clang_debug 82.15% <50.00%> (-0.02%) ⬇️
ubuntu_clang_inflate_allow_invalid_dist 82.17% <50.00%> (-0.02%) ⬇️
ubuntu_clang_inflate_strict 82.51% <50.00%> (-0.02%) ⬇️
ubuntu_clang_mmap 82.61% <50.00%> (-0.25%) ⬇️
ubuntu_clang_pigz 14.13% <0.00%> (-0.08%) ⬇️
ubuntu_clang_pigz_no_optim 11.51% <0.00%> (-0.10%) ⬇️
ubuntu_clang_pigz_no_threads 13.90% <0.00%> (-0.14%) ⬇️
ubuntu_clang_reduced_mem 82.68% <50.00%> (-0.25%) ⬇️
ubuntu_clang_toolchain_riscv ∅ <ø> (∅)
ubuntu_gcc 75.23% <0.00%> (-0.09%) ⬇️
ubuntu_gcc_aarch64 77.41% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_aarch64_compat_no_opt 75.69% <0.00%> (-0.01%) ⬇️
ubuntu_gcc_aarch64_no_acle 76.22% <0.00%> (-0.02%) ⬇️
ubuntu_gcc_aarch64_no_neon 76.22% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_armhf 77.48% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_armhf_compat_no_opt 75.66% <0.00%> (-0.01%) ⬇️
ubuntu_gcc_armhf_no_acle 77.43% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_armhf_no_neon 77.33% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_armsf 74.79% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_armsf_compat_no_opt 74.25% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_benchmark 73.70% <0.00%> (+0.14%) ⬆️
ubuntu_gcc_compat_no_opt 76.86% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_compat_sprefix 73.72% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_m32 73.36% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_mingw_i686 73.57% <0.00%> (-0.18%) ⬇️
ubuntu_gcc_mingw_x86_64 73.73% <0.00%> (+0.12%) ⬆️
ubuntu_gcc_mips 75.04% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_mips64 75.06% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_no_avx2 74.33% <0.00%> (-0.02%) ⬇️
ubuntu_gcc_no_ctz 74.78% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_no_ctzll 74.77% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_no_pclmulqdq 74.32% <0.00%> (-0.02%) ⬇️
ubuntu_gcc_no_sse2 74.59% <0.00%> (+0.04%) ⬆️
ubuntu_gcc_no_sse42 74.21% <0.00%> (-0.02%) ⬇️
ubuntu_gcc_o1 74.22% <0.00%> (-0.02%) ⬇️
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 38.24% <0.00%> (-0.10%) ⬇️
ubuntu_gcc_pigz_aarch64 39.23% <0.00%> (-0.06%) ⬇️
ubuntu_gcc_ppc 74.05% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_ppc64 74.49% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_ppc64_power9 74.66% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_ppc64le 74.50% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_ppc64le_novsx 74.88% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_ppc64le_power9 74.44% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_ppc_no_power8 74.77% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_s390x 74.93% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_s390x_dfltcc 72.00% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_s390x_dfltcc_compat 74.02% <0.00%> (-0.02%) ⬇️
ubuntu_gcc_s390x_no_crc32 74.73% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_sparc64 74.87% <0.00%> (-0.03%) ⬇️
ubuntu_gcc_sprefix 73.37% <0.00%> (-0.03%) ⬇️
win64_gcc 74.12% <0.00%> (-0.03%) ⬇️
win64_gcc_compat_no_opt 74.86% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
inflate_p.h 98.30% <50.00%> (-1.70%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nmoinvaz nmoinvaz added bug Architecture Architecture specific and removed Architecture Architecture specific labels Jun 27, 2023
@Dead2 Dead2 merged commit e5a4a8a into zlib-ng:develop Jun 28, 2023
135 of 136 checks passed
@Dead2 Dead2 mentioned this pull request Jun 28, 2023
@Vogtinator Vogtinator deleted the chunkcopy-noop branch June 29, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since 2.1.0, unpigz hangs in chunkcopy_safe
4 participants