Move C fallback functions into arch/generic [Part 1]

[Dead2]

Due to the scope of this cleanup, this also includes a major cleanup of how we use includefiles, and also ended up cleaning up unneeded includefiles and also some incorrect dependency rules in win32 makefiles.

This PR is limited in scope to doing the following:

• Simplify how we use includes
• Move adler32 fallbacks
• Move crc32 fallbacks

Down the line, this will make it more easily possible to make support for compiling zlib-ng without including the C fallback functions. The grouping of these objects can also (depending on linker behavior) slightly improve instruction cache efficiency for the rest of the code, since they will no longer be interspersed between more important (for performance) code.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70e2fc7) 83.12% compared to head (96a0978) 82.97%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1630      +/-   ##
===========================================
- Coverage    83.12%   82.97%   -0.15%     
===========================================
  Files          133      135       +2     
  Lines        10897    10885      -12     
  Branches      2817     2732      -85     
===========================================
- Hits          9058     9032      -26     
- Misses        1130     1143      +13     
- Partials       709      710       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nmoinvaz]

Looks good. Not sure if crc32_braid_c files needs to be suffixed with _c.

[Dead2]

Looks good. Not sure if crc32_braid_c files needs to be suffixed with _c.

We still have crc32_braid.c in the root folder, so it avoids a conflict. Also I figured perhaps we just slap on the _c for all the files that are only for the C-fallback functions. This makes it easier to spot what files those are, and easier to avoid the mistake of adding non-C-fallback code to those files.

[Dead2]

@nmoinvaz Btw, the linter doesn't like TABs in Makefiles, but the Makefiles break without TABs. Perhaps separate rules can be made for those files?

[nmoinvaz]

Perhaps change lint.yaml to:

git config core.whitespace blank-at-eol