Move C fallback functions into arch/generic [Part 2] #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1631 +/- ##
========================================
Coverage 83.11% 83.12%
========================================
Files 135 135
Lines 10898 10898
Branches 2817 2817
========================================
+ Hits 9058 9059 +1
Misses 1130 1130
+ Partials 710 709 -1 ☔ View full report in Codecov by Sentry. |
nmoinvaz
approved these changes
Jan 4, 2024
| slide_hash_c.lo: $(SRCDIR)/slide_hash_c.c $(SRCTOP)/zbuild.h $(SRCTOP)/deflate.h | ||
| $(CC) $(SFLAGS) $(INCLUDES) -c -o $@ $(SRCDIR)/slide_hash_c.c | ||
|
|
||
|
|
There was a problem hiding this comment.
Is two new lines here intentional?
There was a problem hiding this comment.
It was not intentionally added in that commit, but I had intended to keep 2 empty lines above and below that list from the beginning, to provide a bit more separation in the file. IMO it looks cleaner, but that is just my personal preference.
nmoinvaz
approved these changes
Jan 4, 2024
mtl1979
reviewed
Jan 4, 2024
mtl1979
reviewed
Jan 4, 2024
Dead2
force-pushed
the
no-c-fallback-p2
branch
3 times, most recently
from
ce8ecc4
to
ed65e39
Compare
Also add missing insert_string dependencies to windows makefiles.
…g and avoid attempting to parse the includes more times than needed.
Dead2
force-pushed
the
no-c-fallback-p2
branch
from
ed65e39
to
062149b
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon PR #1630, and needs to be rebased once that is in.
Moves these C functions into arch/generic
Also moves include files out of match_tpl.h to simplify dependency handling and avoid attempting to parse the includes more times than needed.