Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage for SSE2. #1642

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

nmoinvaz
Copy link
Member

No description provided.

We need to turn off support all higher instruction sets in order to hit code
for a lower instruction set.
@nmoinvaz nmoinvaz added Rebase needed Please do a 'git rebase develop yourbranch' Continuous Integration labels Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7425372) 83.03% compared to head (51f0316) 83.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1642      +/-   ##
===========================================
+ Coverage    83.03%   83.12%   +0.09%     
===========================================
  Files          133      133              
  Lines        10897    10898       +1     
  Branches      2816     2817       +1     
===========================================
+ Hits          9048     9059      +11     
+ Misses        1147     1130      -17     
- Partials       702      709       +7     
Flag Coverage Δ
macos_clang ?
macos_gcc ?
ubuntu_clang ?
ubuntu_clang_debug ?
ubuntu_clang_inflate_allow_invalid_dist ?
ubuntu_clang_inflate_strict ?
ubuntu_clang_mmap ?
ubuntu_clang_pigz ?
ubuntu_clang_pigz_no_optim ?
ubuntu_clang_pigz_no_threads ?
ubuntu_clang_reduced_mem ?
ubuntu_clang_toolchain_riscv ?
ubuntu_gcc ?
ubuntu_gcc_aarch64 ?
ubuntu_gcc_aarch64_compat_no_opt ?
ubuntu_gcc_aarch64_no_acle ?
ubuntu_gcc_aarch64_no_neon ?
ubuntu_gcc_armhf ?
ubuntu_gcc_armhf_compat_no_opt ?
ubuntu_gcc_armhf_no_acle ?
ubuntu_gcc_armhf_no_neon ?
ubuntu_gcc_armsf ?
ubuntu_gcc_armsf_compat_no_opt ?
ubuntu_gcc_benchmark ?
ubuntu_gcc_compat_no_opt ?
ubuntu_gcc_compat_sprefix ?
ubuntu_gcc_m32 ?
ubuntu_gcc_mingw_i686 ?
ubuntu_gcc_mingw_x86_64 ?
ubuntu_gcc_mips ?
ubuntu_gcc_mips64 ?
ubuntu_gcc_native_inst ?
ubuntu_gcc_no_avx2 ?
ubuntu_gcc_no_ctz ?
ubuntu_gcc_no_ctzll ?
ubuntu_gcc_no_pclmulqdq ?
ubuntu_gcc_no_sse2 ?
ubuntu_gcc_no_sse42 ?
ubuntu_gcc_o1 ?
ubuntu_gcc_osb ?
ubuntu_gcc_pigz ?
ubuntu_gcc_pigz_aarch64 ?
ubuntu_gcc_ppc ?
ubuntu_gcc_ppc64 ?
ubuntu_gcc_ppc64_power9 ?
ubuntu_gcc_ppc64le ?
ubuntu_gcc_ppc64le_novsx ?
ubuntu_gcc_ppc64le_power9 ?
ubuntu_gcc_ppc_no_power8 ?
ubuntu_gcc_s390x ?
ubuntu_gcc_s390x_dfltcc ?
ubuntu_gcc_s390x_dfltcc_compat ?
ubuntu_gcc_s390x_no_crc32 ?
ubuntu_gcc_sparc64 ?
ubuntu_gcc_sprefix ?
win64_gcc ?
win64_gcc_compat_no_opt ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dead2
Copy link
Member

Dead2 commented Jan 15, 2024

Nice 👍

Copy link
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit 70e2fc7 into zlib-ng:develop Jan 16, 2024
139 checks passed
@nmoinvaz
Copy link
Member Author

nmoinvaz commented Jan 17, 2024

I double checked the coverage, since I didn't get to during rebase, and it looks good. The chunkset_sse2.c calls are being covered correctly now.

image

image

This was referenced May 30, 2024
@Dead2 Dead2 mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Continuous Integration Rebase needed Please do a 'git rebase develop yourbranch'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants