2.1.7 backport release #1740
Merged
2.1.7 backport release #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to turn off support all higher instruction sets in order to hit code for a lower instruction set.
These were left on my part, the inline copy + checksum is the very thing the function is doing.
* POWER8/9 feature checks were enabled even if the toolchain didn't support AT_HWCAP2 * Add detection if we need to include <linux/auxvec.h>
* For COMPAT mode, zlib-config.cmake and zlib-config-version.cmake * For non-COMPAT mode, zlib-ng-config.cmake and zlib-ng-config-version.cmake
madler/zlib#8988e03256e9c80766ac6899e86c3bc57c347efc
madler/zlib#5af7cef45eeef86ddf6ab00b4e363c1eecaf47b6
To avoid warnings when building with -Wmissing-prototypes. madler/zlib#bd9c329c1055a9265812352655ed2eec93f36e92
madler/zlib#431a9b65eacab7efabf2230ba97ff426c0e07f9d
If it is negative, then the code will enter an infinite loop. madler/zlib#36e369e1a54b35a978dc584496af69a07ec2d71a
gz_intmax() is noted in zlib.map. This assures it's always there. madler/zlib#01253ecd7e0a01d311670f2d03c61b82fc12d338
There used to be one, but no more. It is up to the user or vendor to compile zlib. madler/zlib#25263462377fa5c569947a40315815bd59e37f4b
The --version-script linker option is not supported by the linker on AIX systems madler/zlib#ade6825c4996f73d776b0ffa038360762bd318ae
Not all C compilers have a -w option. madler/zlib#88ec24670e9c484219392def5f2f4b5e3f839db3
madler/zlib#51b7f2abdade71cd9bb0e7a373ef2610ec6f9daf
When exporting a CMake target the `install(TARGETS ${ZLIB_INSTALL_LIBRARIES})` is repeated with an `EXPORT` parameter. On Windows this would install the `.dll` files into the `lib` directory.
Set the `EXPORT_NAME` earlier and unconditionally on the `TARGET`. Then move the `EXPORT` to a single `install(TARGETS)`.
Addresses:
3.29.0/share/cmake/Modules/CMakeDependentOption.cmake:89 (message):
Policy CMP0127 is not set: cmake_dependent_option() supports full Condition
Syntax. Run "cmake --help-policy CMP0127" for policy details. Use the
cmake_policy command to set the policy and suppress this warning.
Call Stack (most recent call first):
CMakeLists.txt:107 (cmake_dependent_option)
This warning is for project developers. Use -Wno-dev to suppress it.
Although Git is able to automatically modify line-endings during checkin and checkout, this brings a lot of trouble, especially when trying to use a repository from different platforms (as Windows and Linux). This is due to the fact that Git consults different local gitconfig settings and uses problematic defaults if not set. Therefore, Git should enfoce one type of line-ending (LF) and not consult the local config, which is what the change from this commit does. Signed-off-by: Deniz Bahadir <deniz@code.bahadir.email>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Currently the DFLTCC sanitizer instrumentation is limited to MSAN-unpoisoning the parameter block. Add ASAN and MSAN checks; also MSAN-unpoison the window. Introduce the generic instrument_read(), instrument_write() and instrument_read_write() macros, that are modeled after the repsective functions in the Linux kernel.
The benchmarks fail to compile properly when built with ZLIB_COMPAT. The name of the class cannot have the same name as the function.
- New dockerfile - Using native actions-runner instead of relying on qemu. - To support s390x, we include patches to actions-runner. - Using Almalinux 9 instead of Ubuntu, with functional .Net. - Update CI workflow. - Update readme guide.
Disable unneccessary compilation of tests, benchmarks, docs.
whitespace or end the file with blank lines.
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
The Xeon Phi x200 family of processors (Knights Landing) supports AVX512 (F, CD, ER, PF) but does not support AVX512 (VL, DQ, BW). Because of processors like this, the Intel Software Developer's Manual suggests the bits AVX512 (DQ,BW,VL) are also tested in EBX together with AVX512F before deciding to run AVX512 (DQ,BW,VL) instructions. This also adds a new x86 feature called avx512_common that indicates that AVX512 (F,DQ,BW,VL) are all available and start using this for both adler32_avx512 and crc32_vpclmulqdq implementations because they are both built with -mavx512dq -mavx512bw -mavx512vl. This has been reported downstream as https://bugzilla.redhat.com/show_bug.cgi?id=2280347 .
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Check that calling inflateCopy() twice does not result in memory corruption.
- Fix error in generating list of reports to upload. - Clean up the implementation a bit.
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
|
I presume the Codecov failure is partly due to CI not supporting AVX512. I currently don't have anything "new" that I would want to be included in next 2.1.x release, but isn't already included here. |
Especially when replacing zlib with zlib-ng in old binaries, it is possible that the binary is mixing allocation and deallocation functions from different libraries. As not all old binaries can be rebuild, we should validate the passed in pointer and if the pointer doesn't seem to be allocated with alloc_aligned of zlib-ng, we should not try to adjust the pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the high amount of refactoring changes in
develop, I have decided to target those to a new version branch2.2.x.There is also a lot of fixes and minor improvements, so those will be backported and released as 2.1.7.
To work around the #1708 issue (incompatibility with applications mis-using the zlib zalloc/zfree API), #1710 is merged instead of backporting the much bigger #1713.
Backported Changes
Buildsystem
;by$<SEMICOLON>in generator-expression #1707CI/Test
Cleanup
Refactoring and Optimizations
ARM
Power
RVV
S390x
x86
Misc