-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate CMake target export definitions #1657
Conversation
When exporting a CMake target the `install(TARGETS ${ZLIB_INSTALL_LIBRARIES})` is repeated with an `EXPORT` parameter. On Windows this would install the `.dll` files into the `lib` directory. Set the `EXPORT_NAME` earlier and unconditionally on the `TARGET`. Then move the `EXPORT` to a single `install(TARGETS)`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1657 +/- ##
===========================================
- Coverage 83.15% 83.14% -0.01%
===========================================
Files 135 135
Lines 10898 10898
Branches 2817 2817
===========================================
- Hits 9062 9061 -1
Misses 1127 1127
- Partials 709 710 +1 ☔ View full report in Codecov by Sentry. |
Before:
After:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removes some duplicate files during install step. LGTM
When exporting a CMake target the
install(TARGETS ${ZLIB_INSTALL_LIBRARIES})
is repeated with anEXPORT
parameter. On Windows this would install the.dll
files into thelib
directory.Set the
EXPORT_NAME
earlier and unconditionally on theTARGET
. Then move theEXPORT
to a singleinstall(TARGETS)
.