Fix macOS Github Actions #1720
Merged
Fix macOS Github Actions #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmoinvaz
reviewed
May 6, 2024
| compiler: gcc-10 | ||
| cxx-compiler: g++-10 | ||
| ldflags: -ld_classic |
There was a problem hiding this comment.
Xcode 15 uses a new linker that is not compatible with GCC.
-ld_classic switches to the old linker.
Homebrew gcc@11 and later have a built-in workaround for this issue:
There was a problem hiding this comment.
Oh wow. Ok. Can you add a comment in the yaml about that?
| cmake-args: -DWITH_SANITIZER=Address | ||
| codecov: macos_clang_arm64 | ||
|
|
||
| - name: macOS GCC UBSAN |
There was a problem hiding this comment.
Other pipelines do not show GCC version in it names.
There was a problem hiding this comment.
Yeah, it looks like even for Clang. Ok. Nvm.
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
nmoinvaz
approved these changes
May 6, 2024
This was referenced May 30, 2024
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1719
New macOS pipelines, based on
macos-13- x86 testsmacos-latest- ARM64 testsFix
configurescript (replaced unconditional add-std=c11).Switch to
pythonvenv.