Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect unsupported VS at configure time (and not at compile time) #900

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Detect unsupported VS at configure time (and not at compile time) #900

merged 1 commit into from
Mar 22, 2021

Conversation

tbeu
Copy link
Contributor

@tbeu tbeu commented Mar 20, 2021

I successfully run CMake configuration on recent develop for VS2010. If I open the generated VS solution in VS2010 I get a many compiler errors. Such kind of compiler version requirements should not occur such late during compile time, but at configuration time.

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #900 (8a24158) into develop (bc33b26) will decrease coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #900      +/-   ##
===========================================
- Coverage    75.43%   74.71%   -0.73%     
===========================================
  Files           73       74       +1     
  Lines         8220     7854     -366     
  Branches      1358     1370      +12     
===========================================
- Hits          6201     5868     -333     
+ Misses        1494     1439      -55     
- Partials       525      547      +22     
Flag Coverage Δ
macos_clang 68.65% <ø> (-0.09%) ⬇️
macos_gcc 67.64% <ø> (-0.12%) ⬇️
ubuntu_clang 68.84% <ø> (-0.08%) ⬇️
ubuntu_clang_debug 68.27% <ø> (-0.10%) ⬇️
ubuntu_clang_inflate_allow_invalid_dist 68.82% <ø> (-0.09%) ⬇️
ubuntu_clang_inflate_strict 69.08% <ø> (-0.09%) ⬇️
ubuntu_clang_mmap 68.80% <ø> (-0.12%) ⬇️
ubuntu_clang_msan 69.08% <ø> (-0.09%) ⬇️
ubuntu_gcc 66.92% <ø> (-2.93%) ⬇️
ubuntu_gcc_aarch64 69.86% <ø> (-0.21%) ⬇️
ubuntu_gcc_aarch64_compat_no_opt 67.54% <ø> (-0.24%) ⬇️
ubuntu_gcc_aarch64_no_acle 68.11% <ø> (-0.20%) ⬇️
ubuntu_gcc_aarch64_no_neon 67.79% <ø> (-0.20%) ⬇️
ubuntu_gcc_armhf 70.28% <ø> (-0.21%) ⬇️
ubuntu_gcc_armhf_compat_no_opt 67.54% <ø> (-0.24%) ⬇️
ubuntu_gcc_armhf_no_acle 69.36% <ø> (-0.19%) ⬇️
ubuntu_gcc_armhf_no_neon 69.67% <ø> (-0.20%) ⬇️
ubuntu_gcc_armsf 70.27% <ø> (-0.21%) ⬇️
ubuntu_gcc_armsf_compat_no_opt 67.54% <ø> (-0.24%) ⬇️
ubuntu_gcc_compat_no_opt 68.92% <ø> (-0.23%) ⬇️
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 69.25% <ø> (-0.17%) ⬇️
ubuntu_gcc_no_pclmulqdq 66.39% <ø> (-0.13%) ⬇️
ubuntu_gcc_no_sse2 67.63% <ø> (-0.15%) ⬇️
ubuntu_gcc_no_sse4 66.35% <ø> (-0.17%) ⬇️
ubuntu_gcc_o3 68.92% <ø> (-0.20%) ⬇️
ubuntu_gcc_osb ?
ubuntu_gcc_ppc 70.68% <ø> (-0.23%) ⬇️
ubuntu_gcc_ppc64 69.87% <ø> (-0.22%) ⬇️
ubuntu_gcc_ppc64le 68.85% <ø> (-0.21%) ⬇️
ubuntu_gcc_s390x 68.09% <ø> (-0.19%) ⬇️
ubuntu_gcc_sparc64 70.56% <ø> (-0.24%) ⬇️
win64_gcc 72.82% <ø> (-0.20%) ⬇️
win64_gcc_compat_no_opt 74.16% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
inftrees.c 76.92% <0.00%> (-4.38%) ⬇️
gzwrite.c 48.75% <0.00%> (-4.19%) ⬇️
test/adler32_test.c 60.00% <0.00%> (-3.64%) ⬇️
test/fuzz/minigzip_fuzzer.c 58.33% <0.00%> (-2.66%) ⬇️
gzlib.c 54.47% <0.00%> (-2.52%) ⬇️
test/fuzz/checksum_fuzzer.c 92.00% <0.00%> (-2.24%) ⬇️
test/minideflate.c 57.30% <0.00%> (-2.14%) ⬇️
gzread.c 54.60% <0.00%> (-1.90%) ⬇️
inffast.c 86.52% <0.00%> (-1.75%) ⬇️
crc32_comb.c 80.48% <0.00%> (-1.74%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc33b26...8a24158. Read the comment docs.

Copy link
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CMakeLists.txt Outdated Show resolved Hide resolved
@Dead2 Dead2 merged commit 8e0f38c into zlib-ng:develop Mar 22, 2021
@tbeu tbeu deleted the detect-vs branch March 22, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants