-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace CMAKE_CURRENT_SOURCE_DIR to CMAKE_CURRENT_LIST_DIR #980
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #980 +/- ##
========================================
Coverage 75.81% 75.81%
========================================
Files 74 74
Lines 8082 8082
Branches 1344 1344
========================================
Hits 6127 6127
Misses 1425 1425
Partials 530 530
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Could you explain the use-case here? It is a little unclear what problem you are trying to solve here. |
@Dead2 The change allows using I'm not completely sure if we would want to allow that. |
This change will allow create a configuration like this:
To reuse the architecture detection code from zlib-ng. |
- Minor code cleanup #983 #984 - Fix mpicc compilation #959 - Fix build on NetBSD #964 - Fix build on OpenBSD #970 - Fix build on Cygwin #972 #974 - Fix linter warnings in configure #975 - Spelling fixes #961 - Improve unistd.h handling #960 - Remove stdarg.h detection #976 - CI/Test improvements #977 #981 #985 - Cmake improvements #980
- Minor code cleanup #983 #984 - Fix mpicc compilation #959 - Fix build on NetBSD #964 - Fix build on OpenBSD #970 - Fix build on Cygwin #972 #974 - Fix linter warnings in configure #975 - Spelling fixes #961 - Improve unistd.h handling #960 - Remove stdarg.h detection #976 - CI/Test improvements #977 #981 #985 - Cmake improvements #980 #989
- Fix inflate corruption #982 - Minor code cleanup #983 #984 - Fix mpicc compilation #959 - Fix build on NetBSD #964 - Fix build on OpenBSD #970 - Fix build on Cygwin #972 #974 - Fix linter warnings in configure #975 - Spelling fixes #961 - Improve unistd.h handling #960 - Remove stdarg.h detection #976 - CI/Test improvements #977 #981 #985 - Cmake improvements #980 #989
- Fix inflate corruption #982 - Minor code cleanup #983 #984 - Fix mpicc compilation #959 - Fix build on NetBSD #964 - Fix build on OpenBSD #970 - Fix build on Cygwin #972 #974 - Fix linter warnings in configure #975 - Spelling fixes #961 - Improve unistd.h handling #960 - Remove stdarg.h detection #976 - CI/Test improvements #977 #981 #985 - Cmake improvements #980 #989
Replace
CMAKE_CURRENT_SOURCE_DIR
toCMAKE_CURRENT_LIST_DIR
to allow reuse scriptcmake/detect-arch.cmake
in parent CMake project.