Remove unnecessary test for stdarg.h

[mtl1979]

This style of test breaks if same test is done in project including zlib-ng.

zlib-ng doesn't include stdarg.h in any source files.

[nmoinvaz]

I am seeing stdarg.h included in zconf.h & zlib.h & configure.. maybe those should be removed too?

[nmoinvaz]

Actually looks like va_list is only used in one function: gzvprintf.

[nmoinvaz]

Actually gzprintf too. But perhaps stdarg.h include can be moved to gzwrite.c instead of having it in zlib headers?

[codecov]

Codecov Report

Merging #976 (ec15a94) into develop (c918062) will decrease coverage by 1.65%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #976      +/-   ##
===========================================
- Coverage    77.46%   75.81%   -1.66%     
===========================================
  Files           74       74              
  Lines         8313     8082     -231     
  Branches      1374     1345      -29     
===========================================
- Hits          6440     6127     -313     
- Misses        1339     1425      +86     
+ Partials       534      530       -4     

Flag	Coverage Δ
macos_clang	68.55% <ø> (ø)
macos_gcc	67.45% <ø> (ø)
ubuntu_clang	?
ubuntu_clang_debug	?
ubuntu_clang_inflate_allow_invalid_dist	?
ubuntu_clang_inflate_strict	?
ubuntu_clang_mmap	?
ubuntu_clang_msan	∅ <ø> (∅)
ubuntu_gcc	68.70% <ø> (-5.02%)	⬇️
ubuntu_gcc_aarch64	68.98% <ø> (-5.27%)	⬇️
ubuntu_gcc_aarch64_compat_no_opt	67.32% <ø> (-5.65%)	⬇️
ubuntu_gcc_aarch64_no_acle	67.89% <ø> (-5.40%)	⬇️
ubuntu_gcc_aarch64_no_neon	68.29% <ø> (-5.45%)	⬇️
ubuntu_gcc_armhf	68.97% <ø> (-5.28%)	⬇️
ubuntu_gcc_armhf_compat_no_opt	67.32% <ø> (-5.67%)	⬇️
ubuntu_gcc_armhf_no_acle	69.13% <ø> (-5.31%)	⬇️
ubuntu_gcc_armhf_no_neon	69.46% <ø> (-5.37%)	⬇️
ubuntu_gcc_armsf	68.98% <ø> (-5.28%)	⬇️
ubuntu_gcc_armsf_compat_no_opt	67.32% <ø> (-5.67%)	⬇️
ubuntu_gcc_compat_no_opt	68.71% <ø> (-5.48%)	⬇️
ubuntu_gcc_mingw_i686	0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64	0.00% <ø> (ø)
ubuntu_gcc_no_avx2	69.06% <ø> (-5.14%)	⬇️
ubuntu_gcc_no_pclmulqdq	66.88% <ø> (-5.24%)	⬇️
ubuntu_gcc_no_sse2	68.11% <ø> (-5.07%)	⬇️
ubuntu_gcc_no_sse4	66.85% <ø> (-5.25%)	⬇️
ubuntu_gcc_o3	68.43% <ø> (-5.17%)	⬇️
ubuntu_gcc_osb	70.98% <ø> (-5.55%)	⬇️
ubuntu_gcc_ppc	69.16% <ø> (-5.43%)	⬇️
ubuntu_gcc_ppc64	69.95% <ø> (-5.41%)	⬇️
ubuntu_gcc_ppc64le	68.65% <ø> (-5.44%)	⬇️
ubuntu_gcc_s390x	67.90% <ø> (-5.17%)	⬇️
ubuntu_gcc_sparc64	70.35% <ø> (-5.46%)	⬇️
win64_gcc	70.39% <ø> (ø)
win64_gcc_compat_no_opt	73.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
zutil.c	37.50% <0.00%> (-44.65%)	⬇️
deflate.h	8.33% <0.00%> (-41.67%)	⬇️
trees.c	65.07% <0.00%> (-31.15%)	⬇️
trees_emit.h	67.53% <0.00%> (-27.53%)	⬇️
zutil_p.h	40.00% <0.00%> (-26.67%)	⬇️
arch/x86/compare258_avx.c	96.42% <0.00%> (-3.58%)	⬇️
test/fuzz/example_small_fuzzer.c	86.44% <0.00%> (-2.09%)	⬇️
arch/x86/adler32_avx.c	98.33% <0.00%> (-1.67%)	⬇️
test/fuzz/example_flush_fuzzer.c	88.70% <0.00%> (-1.62%)	⬇️
test/fuzz/minigzip_fuzzer.c	50.76% <0.00%> (-1.62%)	⬇️
... and 29 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c918062...ec15a94. Read the comment docs.

[mtl1979]

@nmoinvaz We basically don't support anything that doesn't have stdarg.h... It's considered standard header nowadays.

[nmoinvaz]

What do you think of removing it from zlib headers/config and moving it to gzwrite.c only where it is used?

[mtl1979]

@nmoinvaz Doesn't compile if I try to remove include for stdarg.h as va_list is used in the headers.