Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SET_BAD macro in inflateBack. #983

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

nmoinvaz
Copy link
Member

@nmoinvaz nmoinvaz commented Jun 2, 2021

It looks like some instances were missed when the macro was created. I noticed it when doing BeyondCompare with inflate.c and infback.c.

@nmoinvaz nmoinvaz added the cleanup Improving maintainability or removing code. label Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #983 (4eaf059) into develop (2c65dce) will decrease coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #983      +/-   ##
===========================================
- Coverage    75.81%   75.44%   -0.37%     
===========================================
  Files           74       74              
  Lines         8082     8291     +209     
  Branches      1343     1370      +27     
===========================================
+ Hits          6127     6255     +128     
- Misses        1425     1499      +74     
- Partials       530      537       +7     
Flag Coverage Δ
macos_clang 68.49% <100.00%> (-0.06%) ⬇️
macos_gcc 67.40% <100.00%> (-0.05%) ⬇️
ubuntu_clang 69.43% <100.00%> (?)
ubuntu_clang_debug 68.84% <100.00%> (∅)
ubuntu_clang_inflate_allow_invalid_dist 69.18% <100.00%> (?)
ubuntu_clang_inflate_strict 69.43% <100.00%> (?)
ubuntu_clang_mmap 69.15% <100.00%> (?)
ubuntu_clang_msan 69.43% <100.00%> (∅)
ubuntu_gcc 68.66% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_aarch64 68.94% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_aarch64_compat_no_opt 67.23% <100.00%> (-0.10%) ⬇️
ubuntu_gcc_aarch64_no_acle 67.84% <100.00%> (-0.06%) ⬇️
ubuntu_gcc_aarch64_no_neon 68.24% <100.00%> (-0.06%) ⬇️
ubuntu_gcc_armhf 68.92% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_armhf_compat_no_opt 67.22% <100.00%> (-0.10%) ⬇️
ubuntu_gcc_armhf_no_acle 69.09% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_armhf_no_neon 69.42% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_armsf 68.94% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_armsf_compat_no_opt 67.22% <100.00%> (-0.10%) ⬇️
ubuntu_gcc_compat_no_opt 68.62% <100.00%> (-0.09%) ⬇️
ubuntu_gcc_mingw_i686 0.00% <0.00%> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <0.00%> (ø)
ubuntu_gcc_no_avx2 69.01% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_no_pclmulqdq 66.83% <100.00%> (-0.06%) ⬇️
ubuntu_gcc_no_sse2 68.06% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_no_sse4 66.79% <100.00%> (-0.06%) ⬇️
ubuntu_gcc_o3 68.39% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_osb 70.94% <100.00%> (-0.04%) ⬇️
ubuntu_gcc_ppc 69.11% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_ppc64 69.90% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_ppc64le 68.60% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_s390x 67.86% <100.00%> (-0.05%) ⬇️
ubuntu_gcc_sparc64 70.31% <100.00%> (-0.05%) ⬇️
win64_gcc 70.33% <100.00%> (-0.06%) ⬇️
win64_gcc_compat_no_opt 73.81% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
infback.c 97.67% <100.00%> (+0.32%) ⬆️
inffast.c 88.27% <0.00%> (-6.87%) ⬇️
test/adler32_test.c 63.63% <0.00%> (-6.37%) ⬇️
zutil.c 32.14% <0.00%> (-5.36%) ⬇️
trees_emit.h 65.82% <0.00%> (-1.71%) ⬇️
trees.c 63.41% <0.00%> (-1.66%) ⬇️
deflate.c 69.93% <0.00%> (-1.43%) ⬇️
uncompr.c 79.06% <0.00%> (-1.42%) ⬇️
inftrees.c 81.29% <0.00%> (-1.29%) ⬇️
test/minideflate.c 59.44% <0.00%> (-1.01%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c65dce...4eaf059. Read the comment docs.

@Dead2
Copy link
Member

Dead2 commented Jun 4, 2021

Nice. I must have completely forgotten to merge the infback changes 😄

@Dead2 Dead2 merged commit 9ee1c5a into zlib-ng:develop Jun 4, 2021
Dead2 added a commit that referenced this pull request Jun 11, 2021
- Minor code cleanup #983 #984
- Fix mpicc compilation #959
- Fix build on NetBSD #964
- Fix build on OpenBSD #970
- Fix build on Cygwin #972 #974
- Fix linter warnings in configure #975
- Spelling fixes #961
- Improve unistd.h handling #960
- Remove stdarg.h detection #976
- CI/Test improvements #977 #981 #985
- Cmake improvements #980
Dead2 added a commit that referenced this pull request Jun 11, 2021
- Minor code cleanup #983 #984
- Fix mpicc compilation #959
- Fix build on NetBSD #964
- Fix build on OpenBSD #970
- Fix build on Cygwin #972 #974
- Fix linter warnings in configure #975
- Spelling fixes #961
- Improve unistd.h handling #960
- Remove stdarg.h detection #976
- CI/Test improvements #977 #981 #985
- Cmake improvements #980 #989
Dead2 added a commit that referenced this pull request Jun 11, 2021
- Fix inflate corruption #982
- Minor code cleanup #983 #984
- Fix mpicc compilation #959
- Fix build on NetBSD #964
- Fix build on OpenBSD #970
- Fix build on Cygwin #972 #974
- Fix linter warnings in configure #975
- Spelling fixes #961
- Improve unistd.h handling #960
- Remove stdarg.h detection #976
- CI/Test improvements #977 #981 #985
- Cmake improvements #980 #989
@Dead2 Dead2 mentioned this pull request Jun 11, 2021
Dead2 added a commit that referenced this pull request Jun 11, 2021
- Fix inflate corruption #982
- Minor code cleanup #983 #984
- Fix mpicc compilation #959
- Fix build on NetBSD #964
- Fix build on OpenBSD #970
- Fix build on Cygwin #972 #974
- Fix linter warnings in configure #975
- Spelling fixes #961
- Improve unistd.h handling #960
- Remove stdarg.h detection #976
- CI/Test improvements #977 #981 #985
- Cmake improvements #980 #989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Improving maintainability or removing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants