Fix Object.getOwnPropertyNames(window) replacement #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In affected browsers, this would cause Object.getOwnPropertyNames(window) to return outdated results.
|
Thanks, looks like a bug after splitting internal modules in |
zloirock
added a commit
that referenced
this pull request
Mar 17, 2016
Fix Object.getOwnPropertyNames(window) replacement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue that would cause
Object.getOwnPropertyNames(window)to return outdated results in some browsers. It would try to call the nativeObject.getOwnPropertyNamesand then fall back, but there was a mistake in the try block so it would always fall back.(This caused some really fun issues when mixing Babel code where some used the transform-runtime plugin and some didn't. Before I realized the cause of it was so simple, I started documenting this example because I imagined the fix would be much more involved.)