Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promise.prototype.finally per tc39 0716 #225

Closed
clavecoder opened this issue Jul 30, 2016 · 10 comments
Closed

Add Promise.prototype.finally per tc39 0716 #225

clavecoder opened this issue Jul 30, 2016 · 10 comments

Comments

@clavecoder
Copy link
Contributor

Since TC39 moved Promise.prototype.finally to Stage 2 in the 07 '16 meeting, add to core.js. Was requested previously as #70, by others.

@zloirock
Copy link
Owner

Makes sense. Feel free to add a PR.

@xjamundx
Copy link

xjamundx commented Sep 1, 2016

Any movement here?

This one seems alright:
https://github.com/matthew-andrews/Promise.prototype.finally/blob/master/finally.js

@zloirock
Copy link
Owner

zloirock commented Sep 1, 2016

@xjamundx now I have some problems with time, it will be added when I'll be a little freer.

@clavecoder
Copy link
Contributor Author

I'll integrate this weekend, promise!

@zloirock
Copy link
Owner

zloirock commented Sep 1, 2016

@clavecoder 👍

@xjamundx
Copy link

xjamundx commented Sep 1, 2016

Thanks friends!

@Jessidhia
Copy link

I'd suggest basing it on the proposal's own polyfill at https://github.com/tc39/proposal-promise-finally/blob/master/polyfill.js. It takes one less microtask tick to settle and correctly supports @@species (though you may be able to use core-js's _species-constructor).

@clavecoder
Copy link
Contributor Author

clavecoder commented Sep 5, 2016

PR (#238) created, as promised. Tripped up a bit, perhaps, with the reserved word function name and, possibly, by the species of Promise. Preliminary reviews very welcome!

@zloirock
Copy link
Owner

ed59a9c, 86ed553, fd70e24, 0bc7a9e

@clavecoder
Copy link
Contributor Author

Thanks for bringing it home!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants