Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change HTTP timeout to be a float #73

Open
ngngng opened this issue Mar 13, 2018 · 1 comment
Open

Change HTTP timeout to be a float #73

ngngng opened this issue Mar 13, 2018 · 1 comment
Labels
enhancement
Milestone
Initial Release

Comments

@ngngng
Copy link

ngngng commented Mar 13, 2018

Hi,
I wanted to set the timeout in http to a value less than a second
However the minimum allowed value is 1 second (I wanted for example 0.2 second, 200 milliseconds)
Thanks!
@zakird zakird removed their assignment Mar 14, 2018
@zakird
Copy link
Member

zakird commented Mar 14, 2018

@ngngng We'd be happy to see this! Would you be willing to submit a pull request that makes the change?

@zakird zakird changed the title feature request: can you please change the type of timeout parameter in http to be a float number instead of uint Change HTTP timeout to be a float Apr 4, 2018
@zakird zakird added this to the ZGrab 1.0 milestone Apr 4, 2018
This was referenced May 1, 2018
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Initial Release
Development

No branches or pull requests
3 participants
@zakird @ngngng @justinbastress