Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls.go/arguments: Allow a comma-separated list of hex values for --cipher-suites #85

Closed
justinbastress opened this issue Mar 22, 2018 · 1 comment
Closed

tls.go/arguments: Allow a comma-separated list of hex values for --cipher-suites #85

justinbastress opened this issue Mar 22, 2018 · 1 comment
Assignees
@zakird
Labels
enhancement

Comments

@justinbastress
Copy link
Contributor

The docs say (https://github.com/zmap/zgrab2/blob/master/tls.go#L50) "A list of cipher suites to use.", but currently that really means "the name of one of our pre-defined lists".

Take values like "0xC020,0xC030,0xC02F". Less clear whether we should accept const values like "TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384".
@justinbastress justinbastress changed the title Allow a comma-separated list of hex values for --cipher-suites tls.go/arguments: Allow a comma-separated list of hex values for --cipher-suites Mar 22, 2018
@zakird zakird self-assigned this Mar 22, 2018
@zakird
Copy link
Member

zakird commented Apr 4, 2018

This was fixed by #88.

@zakird zakird closed this as completed Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zakird zakird

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zakird @justinbastress