Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing RPL_TOPICWHOTIME from server results in incorrect RPL_TOPICWHOTIME sent to client #1889

Closed
progval opened this issue Dec 16, 2023 · 0 comments

Comments

@progval
Copy link

progval commented Dec 16, 2023

I got a report from a user of my server that sometimes, ZNC sends their client an invalid RPL_TOPICWHOTIME message.

The expected parameter list is: "<client> <channel> <nick> <setat>", but when the server omits RPL_TOPICWHOTIME, send ZNC sends a RPL_TOPICWHOTIME to the client with these parameters: `" 0".

Example log:

[2023-12-16 21:42:43.998187] (admin@odin/Matrix) ZNC -> CLI [:user:matrix.example.com!user@matrix.example.com JOIN #channel:matrix.example.com]
[2023-12-16 21:42:43.998265] (admin/Matrix) IRC -> ZNC [:server. 332 user:matrix.example.com #channel:matrix.example.com :[Alien4ports]]
[2023-12-16 21:42:43.998295] (admin@odin/Matrix) ZNC -> CLI [:server. 332 user:matrix.example.com #channel:matrix.example.com :[Alien4ports]]
[2023-12-16 21:42:43.998334] (admin/Matrix) IRC -> ZNC [:server. 353 user:matrix.example.com = #channel:matrix.example.com:user:matrix.example.com!abranson@matrix.example.com user:matrix.example.com!user@matrix.example.com user:matrix.example.com!djones@matrix.example.com user:matrix.example.com!frajo@matrix.example.com user:matrix.example.com!jpetrell@matrix.example.com user:matrix.example.com!pketolai@matrix.example.com]
[2023-12-16 21:42:43.998390] (admin@odin/Matrix) ZNC -> CLI [:server. 353 user:matrix.example.com = #channel:matrix.example.com:user:matrix.example.com user:matrix.example.com user:matrix.example.com user:matrix.example.com user:matrix.example.com user:matrix.example.com]
[2023-12-16 21:42:43.998416] (admin/Matrix) IRC -> ZNC [:server. 366 user:matrix.example.com #channel:matrix.example.com :End of /NAMES list]
[2023-12-16 21:42:43.998436] (admin@odin/Matrix) ZNC -> CLI [:server. 366 user:matrix.example.com #channel:matrix.example.com :End of /NAMES list]
[...]
[2023-12-16 21:44:54.504762] (admin@odin/Matrix) ZNC -> CLI [:user:matrix.example.com!user@matrix.example.com JOIN #channel:matrix.example.com]
[2023-12-16 21:44:54.504774] (admin@odin/Matrix) ZNC -> CLI [:server. 332 user:matrix.example.com #channel:matrix.example.com :[Alien4ports]]
[2023-12-16 21:44:54.504788] (admin@odin/Matrix) ZNC -> CLI [:server. 333 user:matrix.example.com #channel:matrix.example.com 0]
[2023-12-16 21:44:54.504820] (admin@odin/Matrix) ZNC -> CLI [:server. 353 user:matrix.example.com = #channel:matrix.example.com:user:matrix.example.com user:matrix.example.com user:matrix.example.com user:matrix.example.com user:matrix.example.com user:matrix.example.com] 
[2023-12-16 21:44:54.504838] (admin@odin/Matrix) ZNC -> CLI [:server. 366 user:matrix.example.com #channel:matrix.example.com :End of /NAMES list.]

ZNC version: 1.8.2

Loaded modules: webadmin, log, chansaver, adminlog, playback, lastseen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant