Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land fraction should check bounds before running #36

Closed
znicholls opened this issue Feb 1, 2019 · 0 comments · Fixed by #75
Closed

Land fraction should check bounds before running #36

znicholls opened this issue Feb 1, 2019 · 0 comments · Fixed by #75
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@znicholls
Copy link
Owner

Describe the bug

At the moment, when crunching with e.g. get_scm_timeseries, land_mask_threshold expects a percentage (i.e. 0-100) value. Sometimes data is provided with a fraction (i.e. 0-1) value. get_scm_timeseries should do some sort of sensible test.

Failing Test

tas.get_scm_timeseries(
sftlf_cube=sftlf,
land_mask_threshold=50,
areacella_scmcube=None
)

on a cube which has sftlf values from 0-1

Expected behavior

A warning that the threshold looks wrong.

Screenshots

If applicable, add screenshots to help explain your problem.

System (please complete the following information):

  • OS: macOS
  • Python version 3.7

Additional context

Add any other context about the problem here.

@znicholls znicholls added enhancement New feature or request good first issue Good for newcomers labels Feb 1, 2019
@znicholls znicholls added this to the v2.0 milestone May 28, 2019
@znicholls znicholls self-assigned this May 28, 2019
@znicholls znicholls mentioned this issue Jul 21, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant