Empty envelope sender in daemon notifications #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Znuny daemon notifications are sent with nonempty envelope sender; in case of delivery failures bounces may be unnecessarry generated. No such problem in regular notifications https://github.com/znuny/Znuny/blob/dev/Kernel/System/Ticket/Event/NotificationEvent/Transport/Email.pm#L186 This mod sets empty evelope sender for deamon notifications also. Related: https://datatracker.ietf.org/doc/html/rfc5321#section-4.1.1.2 Author-Change-Id: IB#1111343
Author-Change-Id: IB#1111343
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Znuny daemon notifications are sent with nonempty envelope sender;
in case of delivery failures bounces may be unnecessary generated.
No such problem in regular notifications
https://github.com/znuny/Znuny/blob/dev/Kernel/System/Ticket/Event/NotificationEvent/Transport/Email.pm#L186
This mod sets empty envelope sender for daemon notifications also.
Type of change
Additional information
Replaces: #161
Related: https://datatracker.ietf.org/doc/html/rfc5321#section-4.1.1.2
Author-Change-Id: IB#1111343
Checklist