Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SectorNordAG: Fixed format of file content in AdminPackageManager's ViewDiff mask #486

Conversation

ZTrotter
Copy link
Contributor

Proposed change

After manually adjusting a file in an installed package and viewing the differences using AdminPackageManager's ViewDiff, line breaks aren't displayed, making it challenging to read. Furthermore, special UTF-8 characters like "ß" and "ü" aren't rendered correctly, due to the absence of an appropriate encoder. I suggest implementing line breaks for better readability and incorporating an encoder to correctly display special UTF-8 characters.

image2

Type of change

🐞 bug 🐞

Additional information

Steps to reproduce

  • Install a package over the PackageManager
  • Navigate to package's source code and make and save a few changes (e.g with Command Shell)
  • Go to AdminPackageManager
  • Select changed package, then click on "View Changes".
  • Changes will be displayed without line breaks or correctly encoded characters

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@rkaldung rkaldung added 1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified. labels Aug 23, 2023
@NiklasSchmitt NiklasSchmitt self-requested a review November 6, 2023 08:22
@NiklasSchmitt NiklasSchmitt merged commit 9f3f118 into znuny:dev Nov 6, 2023
11 of 14 checks passed
@NiklasSchmitt NiklasSchmitt added this to the rel-7_0_13 milestone Nov 6, 2023
znuny-robo pushed a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants