Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump factory_bot_rails from 4.11.1 to 5.0.1 #3072

Merged
merged 9 commits into from Sep 11, 2019

Conversation

@dependabot-preview
Copy link
Contributor

commented Feb 11, 2019

Bumps factory_bot_rails from 4.11.1 to 5.0.1.

Release notes

Sourced from factory_bot_rails's releases.

v5.0.1

Bugfix: Avoid watching files and directories that don't exist (to avoid a file watching bug in Rails https://github-redirect.dependabot.com/rails/rails/issues/32700). Thanks to y-yagi for this fix!

v5.0.0

  • Added: calling reload! in the Rails console will reload any factory definition files that have changed
  • Added: support for custom generator templates
  • Added: definition_file_paths configuration option, making it easier to place factories in custom locations
  • Changed: namespaced models are now generated inside a directory matching the namespace
  • Changed: added newline between factories generated into the same file
  • Removed: support for EOL version of Ruby and Rails

v5.0.0.rc2

No release notes provided.

v5.0.0.rc1

  • Added: calling reload! in the Rails console will reload any factory definition files that have changed
  • Added: support for custom generator templates
  • Added: definition_file_paths configuration option, making it easier to place factories in custom locations
  • Changed: namespaced models are now generated inside a directory matching the namespace
  • Changed: added newline between factories generated into the same file
  • Removed: support for EOL version of Ruby and Rails
Changelog

Sourced from factory_bot_rails's changelog.

5.0.1
Bugfix: Avoid watching files and directories that don't exist (to avoid a
file watching bug in Rails https://github-redirect.dependabot.com/rails/rails/issues/32700)

5.0.0
Added: calling reload! in the Rails console will reload any factory definition files that have changed
Added: support for custom generator templates
Added: definition_file_paths configuration option, making it easier to place factories in custom locations
Changed: namespaced models are now generated inside a directory matching the namespace
Changed: added newline between factories generated into the same file
Removed: support for EOL version of Ruby and Rails

Commits
  • 9c90d6b Bump version to v5.0.1 [ci skip]
  • a9cce0b Update copyright notice to 2019 [ci skip]
  • f718048 Only add exist paths to reloading target
  • e650992 Use compatible sqlite3 version in test application
  • df44185 Bump version to 5.0.0 [ci skip]
  • 3c300ec Update README section about generator template
  • f91bcf2 Avoid committing factory_bot_rails-*.gem files
  • 79a53a7 Bump version to 5.0.0.rc2 [ci skip]
  • 75806f3 Bump version to 5.0.0.rc1 [ci skip]
  • ab8ed30 Use an older version of bundler
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

spec/factories/workflows.rb Outdated Show resolved Hide resolved
spec/factories/workflows.rb Outdated Show resolved Hide resolved
spec/factories/workflows.rb Outdated Show resolved Hide resolved
spec/factories/workflows.rb Outdated Show resolved Hide resolved
spec/factories/workflows.rb Outdated Show resolved Hide resolved
spec/factories/workflows.rb Outdated Show resolved Hide resolved
spec/factories/workflows.rb Show resolved Hide resolved
spec/factories/workflows.rb Outdated Show resolved Hide resolved
spec/factories/workflow_contents.rb Outdated Show resolved Hide resolved
spec/factories/workflow_contents.rb Outdated Show resolved Hide resolved
spec/factories/workflows.rb Show resolved Hide resolved
spec/factories/classifications.rb Outdated Show resolved Hide resolved
spec/factories/collections.rb Show resolved Hide resolved
spec/factories/projects.rb Show resolved Hide resolved
spec/factories/translations.rb Show resolved Hide resolved
spec/factories/translations.rb Show resolved Hide resolved
dependabot-bot and others added 3 commits Feb 11, 2019
fixed using rubocop --require rubocop-rspec --only FactoryBot/AttributeDefinedStatically --auto-correct

https://thoughtbot.com/blog/deprecating-static-attributes-in-factory_bot-4-11
ignore dsl is deprecated
@camallen camallen force-pushed the dependabot/bundler/factory_bot_rails-5.0.1 branch from e436878 to 96c87ad Apr 8, 2019
spec/factories/subjects.rb Show resolved Hide resolved
spec/factories/subjects.rb Show resolved Hide resolved
spec/factories/workflows.rb Show resolved Hide resolved
spec/factories/workflows.rb Show resolved Hide resolved
spec/factories/access_tokens.rb Show resolved Hide resolved
@camallen camallen requested a review from zwolf Apr 9, 2019
@dependabot-preview

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

A newer version of factory_bot_rails exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@stale

This comment has been minimized.

Copy link

commented Aug 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 13, 2019
@stale stale bot closed this Aug 20, 2019
@dependabot-preview

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/factory_bot_rails-5.0.1 branch Aug 20, 2019
@zwolf zwolf restored the dependabot/bundler/factory_bot_rails-5.0.1 branch Aug 20, 2019
@zwolf zwolf reopened this Aug 20, 2019
@stale stale bot removed the stale label Aug 20, 2019
@zwolf

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

This slipped between the cracks. Conflicts resolved, this should be good to go. I'll give it my own lgtm and let you have a final look before merging, @camallen.

@zwolf zwolf requested a review from camallen Aug 20, 2019
@zwolf
zwolf approved these changes Aug 20, 2019
@github-actions github-actions bot added the approved label Aug 20, 2019
@camallen camallen merged commit a59b4c6 into master Sep 11, 2019
5 checks passed
5 checks passed
Label when approved Label when approved
Details
Hound 15 violations found.
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@camallen camallen deleted the dependabot/bundler/factory_bot_rails-5.0.1 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.