Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.8 #114

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Add support for Python 3.8 #114

merged 2 commits into from
Nov 7, 2019

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Nov 6, 2019

I'm skipping the MacOS build on Travis because 3.8 is not available yet from https://github.com/MacPython/terryfy

Needed for #113.

I'm skipping the MacOS build on Travis because 3.8 is not available yet
from https://github.com/MacPython/terryfy
@mgedmin
Copy link
Member Author

mgedmin commented Nov 6, 2019

Hey, the terryfy README recommends https://github.com/matthew-brett/multibuild as a more maintained solution, maybe we want to switch to that? Multibuild added 3.8 support 13 days ago.

@mgedmin
Copy link
Member Author

mgedmin commented Nov 6, 2019

Ha ha I forgot about #111.

@mgedmin
Copy link
Member Author

mgedmin commented Nov 7, 2019

I would like to merge this. Does anyone want to review?

Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants