-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added python3.8 tox & travis tests #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also a Python version check in .manylinux-install.sh
.
And also appveyor.yml, but there we're blocked on appveyor/ci#3142 which will probably take a week or two.
And also a CHANGES.rst update about adding support for Python 3.8, but I feel uncomfortable declaring that before we can build and upload wheels to PyPI for all platforms.
(Speaking of all platforms, .travis.yml is also building on Mac OS -- is 3.8 available there?)
@@ -7,7 +7,8 @@ for PYBIN in /opt/python/*/bin; do | |||
if [[ "${PYBIN}" == *"cp27"* ]] || \ | |||
[[ "${PYBIN}" == *"cp35"* ]] || \ | |||
[[ "${PYBIN}" == *"cp36"* ]] || \ | |||
[[ "${PYBIN}" == *"cp37"* ]]; then | |||
[[ "${PYBIN}" == *"cp37"* ]] || \ | |||
[[ "${PYBIN}" == *"cp38"* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And now we will learn if the manylinux docker images have already been updated to contain Python 3.8! :)
(I've no idea who maintains those images.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we won't because manylinux builds are for git tags only.
I've a workaround for Appveyor builds in #114. |
Superseded by #114. |
No description provided.