Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #43

Conversation

wosc
Copy link
Contributor

@wosc wosc commented Mar 22, 2024

The imp module has been removed in 3.12, replacing it with types.ModuleType was taken from pallets/flask@2de525c

Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run into the Python 3.12 compatibility problem and can confirm this PR fixes the problem.

@jensens
Copy link
Member

jensens commented Apr 28, 2024

@icemac Is this package is still maintained? This PR would be important to get merged and released.
CI needs fixing too.
To pass the burden this could be moved (or forked under a different name) to zope or plone organizations if this helps.

/cc @gotcha

@icemac
Copy link
Member

icemac commented Apr 29, 2024

@jensens This package is still maintained, but it seems to be a good idea to move it to zopefoundation and maybe rename it to zope.pytestlayer.

I can do the move and integrate it into the workflow there.

@gotcha
Copy link
Member

gotcha commented Apr 29, 2024

@icemac Would be great. This is a piece of software I am proud having been part of.

@icemac icemac mentioned this pull request Apr 29, 2024
2 tasks
@icemac
Copy link
Member

icemac commented Apr 29, 2024

I moved gocept.pytestlayer to zope.pytestlayer and integrated into meta/config, see #44. But there are some problems due to pytest >= 8 there. Any help would be appreciated.

@icemac icemac changed the base branch from master to config-with-pure-python-template-7713fd86 May 8, 2024 06:02
@icemac icemac mentioned this pull request May 8, 2024
@icemac
Copy link
Member

icemac commented May 8, 2024

Superseded by #46.

@icemac icemac closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants