Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and integrate into meta/config. #44

Merged
merged 4 commits into from
May 15, 2024

Conversation

icemac
Copy link
Member

@icemac icemac commented Apr 29, 2024

Open issues:

@icemac icemac self-assigned this Apr 29, 2024
@icemac icemac added the help wanted Extra attention is needed label Apr 29, 2024
@icemac
Copy link
Member Author

icemac commented May 7, 2024

See #45 for my attempt to add support for pytest 8.

icemac and others added 2 commits May 8, 2024 08:01
Co-authored-by: Wolfgang Schnerring <wolfgang.schnerring@zeit.de>
@icemac icemac marked this pull request as ready for review May 8, 2024 06:19
@icemac icemac enabled auto-merge (squash) May 8, 2024 06:20
@icemac icemac requested review from wosc, gotcha and jensens May 8, 2024 06:20
@icemac icemac added enhancement New feature or request and removed help wanted Extra attention is needed labels May 8, 2024
Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without testing it locally: LGTM

Copy link
Contributor

@wosc wosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the boilerplate in detail, but in general it looks fine to me. Thanks for reorganizing!

@ericof
Copy link
Member

ericof commented May 15, 2024

@icemac Could you merge this and make a release of zope.pytestlayer?
I want to make a new release of pytest-plone already with 3.12 support (even if restricting it to pytest <8)

@ericof ericof self-requested a review May 15, 2024 11:03
Copy link
Member

@ericof ericof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icemac icemac merged commit 7fc1b2c into master May 15, 2024
12 checks passed
@icemac icemac deleted the config-with-pure-python-template-7713fd86 branch May 15, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants