Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and integrate into meta/config. #44

Merged
merged 4 commits into from
May 15, 2024
Merged

Rename and integrate into meta/config. #44

merged 4 commits into from
May 15, 2024

Conversation

icemac
Copy link
Member

@icemac icemac commented Apr 29, 2024 •
edited

Open issues:

@icemac icemac self-assigned this Apr 29, 2024
@icemac icemac added the help wanted Extra attention is needed label Apr 29, 2024
@icemac icemac mentioned this pull request Apr 29, 2024
Closed
@icemac
Copy link
Member Author

icemac commented May 7, 2024

See #45 for my attempt to add support for pytest 8.

icemac and others added 2 commits May 8, 2024 08:01
@icemac
Restrict to pytest 7 to get it working for now.
e2ee0ce
@icemac @wosc
Add support for Python 3.12 (#46)
a380203 
Co-authored-by: Wolfgang Schnerring <wolfgang.schnerring@zeit.de>
@icemac icemac marked this pull request as ready for review May 8, 2024 06:19
@icemac icemac enabled auto-merge (squash) May 8, 2024 06:20
@icemac icemac requested review from wosc, gotcha and jensens May 8, 2024 06:20
@icemac icemac added enhancement New feature or request and removed help wanted Extra attention is needed labels May 8, 2024
@icemac icemac mentioned this pull request May 8, 2024
Open
jensens
jensens approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without testing it locally: LGTM

wosc
wosc approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@wosc wosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the boilerplate in detail, but in general it looks fine to me. Thanks for reorganizing!

@ericof
Copy link
Member

ericof commented May 15, 2024

@icemac Could you merge this and make a release of zope.pytestlayer?
I want to make a new release of pytest-plone already with 3.12 support (even if restricting it to pytest <8)

@ericof ericof mentioned this pull request May 15, 2024
Closed
@ericof ericof self-requested a review May 15, 2024 11:03
ericof
ericof approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@ericof ericof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icemac icemac merged commit 7fc1b2c into master May 15, 2024
12 checks passed
@icemac icemac deleted the config-with-pure-python-template-7713fd86 branch May 15, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensens jensens jensens approved these changes

@ericof ericof ericof approved these changes

@wosc wosc wosc approved these changes

@gotcha gotcha Awaiting requested review from gotcha

Assignees

@icemac icemac

Labels
enhancement New feature or request
Projects
Alpine City Sprint 2023 and beyond
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@icemac @ericof @jensens @wosc