Quote attribute values in CSS selectors #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures are caused by #62. |
|
I'd be happy to rebase once #64 is reviewed and merged. |
My editor highlights flake8 warnings. I don't want it to mistakenly tell me 'import io' is unused when it's actually used inside a doctest.
mgedmin
force-pushed
the
fix-css-selector
branch
from
ac4e14c
to
f183cb9
Compare
icemac
previously requested changes
Feb 6, 2019
icemac
approved these changes
Feb 6, 2019
|
Oh yeah, a changelog entry is a must! (For the other PR also.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61.
I've reviewed other uses of
html.select()and AFAICs we're not doing anything else wrong.