Fix tests on master #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browser.cookies.change() helpfully makes the cookie disappear if you set an expirationd date in the past. We had a narrative test that tried to use a fixed future date (2019 January 1st) that is no longer a future date. Now in a regular unit test I could do things like datetime.date.today() and write a test that will never expire. But this is a doctest so I'll just shift all the dates 10 years into the future and leave the problem for some unlucky future person down the road. Fixes #62.
This was referenced Feb 5, 2019
jamadden
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browser.cookies.change() helpfully makes the cookie disappear if you set
an expirationd date in the past.
We had a narrative test that tried to use a fixed future date (2019
January 1st) that is no longer a future date.
Now in a regular unit test I could do things like datetime.date.today()
and write a test that will never expire. But this is a doctest so I'll
just shift all the dates 10 years into the future and leave the problem
for some unlucky future person down the road.
Fixes #62.