Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Versions - There are none #59

Closed
brendanmeyer opened this issue Oct 16, 2017 · 6 comments
Closed

File Versions - There are none #59

brendanmeyer opened this issue Oct 16, 2017 · 6 comments

Comments

@brendanmeyer
Copy link

Hi

I was hoping you would be able to implement file versions into the Windows builds.

There is currently incorrect information and no real file information in the installed files, see below.

Thank you
Brendan

image

@dstillman
Copy link
Member

We might be able to add this to the build script with https://github.com/electron/rcedit.

@brendanmeyer
Copy link
Author

That would be very helpful with version detection in SCCM

dstillman added a commit that referenced this issue Aug 19, 2021
dstillman added a commit that referenced this issue Aug 19, 2021
dstillman added a commit that referenced this issue Aug 19, 2021
@dstillman
Copy link
Member

dstillman commented Aug 19, 2021

What matters here, the "File version" field or the "Product version" field? And is it just the primary .exe that matters?

https://forums.zotero.org/discussion/91128/managed-install-automatic-updates-issue/p1 suggests that this is impeding automated updates (which wasn't at all clear to me from the above — sorry), but I don't know anything about SCCM, so I'd need some guidance here as to what the actual problem is. Is the goal just to have one file/property that can be easily checked to determine the installed version?

dstillman added a commit that referenced this issue Aug 19, 2021
@brendanmeyer
Copy link
Author

File Version please, with the version to match the changelog version number
Thanks

dstillman added a commit that referenced this issue Aug 20, 2021
@dstillman
Copy link
Member

OK, I've added this for the current Zotero beta channel. The current release version of 5.0.96.3 is still 5.0.0.0, but the next release will have a proper version — either 5.0.96.4 if there's another Zotero 5 release or 6.0.0.0/6.0.1.0/6.0.2.0 for Zotero 6.0/6.0.1/6.0.2.

Since File Version seems to be limited to four integers, that won't show a proper version for beta builds — e.g., 5.0.97-beta.38 and all future 5.0.97 betas will be 5.0.97.0, as would the release build of 5.0.97. But people using SCCM probably aren't going to be managing beta builds. If someone really wants to, I assume there's a way to use Product Version, which will be a Mozilla Manifest Version Format string (e.g., 5.0.97-beta.37+ddc7be75c).

@brendanmeyer
Copy link
Author

Thank you very much

This should be very helpful, and I look forward to the next version release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants