Change Transform text so that sentence case capitalizes after :, ?, ! Th... #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
addresses #293 |
|
any chance to get this into the next release? - seems small, low risk, & useful to me |
| var newVal = val.length ? val[0].toUpperCase()+val.substr(1).toLowerCase() : val; | ||
| //capitalize after :, ?, ! and remove space(s) before those analogous to capitalizeTitle function | ||
| var titleparts = val.split(/\s*([:\?!]\s?)/); | ||
| var fulltitle = new Array; |
|
But before you address the above comments, can you just do this with a single regexp replace? |
|
done - looking much neater now. |
|
Great, thanks. Can you rebase and squash this into a single commit? |
… This is in line with English usage and this function is principally useful for English titles. also deal with punctuation at the beginning of title Also fix capitalizeTitle to work with quotation marks and Spanish beginning punctuation. Also adds ? and ! as punctuation after which it always capitalizes switch sentence case conversion to a regex; I'm leaving capitalizeTitle as the substring routine, it's the same length and probably slightly more efficient.
|
done |
dstillman
added a commit
that referenced
this pull request
Jan 14, 2014
Change Transform text so that sentence case capitalizes after :, ?, ! Th...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...is is in line with English usage and this function is principally useful for English titles.