Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user agent class support #1348

Merged
merged 11 commits into from
Jul 20, 2016
Merged

Remove user agent class support #1348

merged 11 commits into from
Jul 20, 2016

Conversation

mworrell
Copy link
Member

@mworrell mworrell commented Jul 8, 2016

Fixes #1347

This removes the ua_classifier and support for user-agent specific templates.

To do:

  • Documentation
  • Testing

@mworrell mworrell added this to the 1.0 milestone Jul 8, 2016
@mworrell mworrell changed the title [WIP] Remove user agent class Remove user agent class support Jul 8, 2016
@mworrell
Copy link
Member Author

mworrell commented Jul 8, 2016

@arjan @ddeboer ready to be merged, can you test drive it?

@mmzeeman
Copy link
Member

mmzeeman commented Jul 11, 2016

BTW: This looks like a nice erlang application which does user agent identification.

https://github.com/SiftLogic/uaparser

It recognizes the recent safari as:

[{browser,[{name,<<"safari">>},{family,<<"safari">>},{manufacturer,<<"apple">>},{type,<<"web_browser">>},{renderer,<<"webkit">>},{version,<<"9.1.1">>},{version_details,[{major,9},{minor,1},{patch,1}]}]},
 {os,[{name,<<"mac os x">>},{family,<<"mac_os_x">>},{manufacturer,<<"apple">>},{type,<<"computer">>},{version,<<"10_11_5">>},{version_details,[{major,10},{minor,11},{patch,5}]}]}]

@ddeboer
Copy link
Member

ddeboer commented Jul 11, 2016

@mmzeeman The current idea is just to throw out User Agent identification, as it can and should be solved on the CSS instead (media queries and the like). Do you have a user case for User Agent identification in Erlang?

@mworrell Will try to find some time for testing.

@mmzeeman
Copy link
Member

@ddeboer Indeed, for template selection browser classification is not needed anymore. But for informational purposes it is sometimes needed to have browser identification. Think about support forms, statistics, ugly hacks (sometimes needed). My current use case is to make an informational page of all logged in users of an account to a supervisor. This page needs some browser information, like "Safari on iPod", "Firefox on windows 8".

@mworrell
Copy link
Member Author

Checked with @ArthurClemens, going to merge this.

@mworrell mworrell merged commit 49bf4f3 into master Jul 20, 2016
@mworrell mworrell deleted the remove-user-agent-class branch July 20, 2016 09:20
@ddeboer
Copy link
Member

ddeboer commented Jul 25, 2016

@mworrell Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants