-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove user agent class support #1348
Conversation
BTW: This looks like a nice erlang application which does user agent identification. https://github.com/SiftLogic/uaparser It recognizes the recent safari as:
|
@ddeboer Indeed, for template selection browser classification is not needed anymore. But for informational purposes it is sometimes needed to have browser identification. Think about support forms, statistics, ugly hacks (sometimes needed). My current use case is to make an informational page of all logged in users of an account to a supervisor. This page needs some browser information, like "Safari on iPod", "Firefox on windows 8". |
Checked with @ArthurClemens, going to merge this. |
@mworrell Thanks! |
Fixes #1347
This removes the
ua_classifier
and support for user-agent specific templates.To do: